integ-cli: skip test assuming -H is unix://... #11216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestCliProxyDisableProxyUnixSock` verifies that HTTP_PROXY env var is used when DOCKER_HOST is not set and cli connects to `unix://...` by default. In the windows/darwin CLI CIs, daemon is on remote host and we always connect via `tcp://`, therefore this test fails very straight. Skipping this test to run only on "same host daemon" assumption. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
LGTM |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Mar 9, 2015
…ableProxyUnixSock-fix integ-cli: skip test assuming -H is unix://...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestCliProxyDisableProxyUnixSockverifies that HTTP_PROXY env var isused when DOCKER_HOST is not set and cli connects to
unix://...bydefault.
In the windows/darwin CLI CIs, daemon is on remote host and we always
connect via
tcp://, therefore this test fails very straight. Skippingthis test to run only on "same host daemon" case.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @cpuguy83 (test author) @duglin