New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ-cli: skip test assuming -H is unix://... #11216

Merged
merged 1 commit into from Mar 9, 2015

Conversation

Projects
None yet
5 participants
@ahmetb
Contributor

ahmetb commented Mar 6, 2015

TestCliProxyDisableProxyUnixSock verifies that HTTP_PROXY env var is
used when DOCKER_HOST is not set and cli connects to unix://... by
default.

In the windows/darwin CLI CIs, daemon is on remote host and we always
connect via tcp://, therefore this test fails very straight. Skipping
this test to run only on "same host daemon" case.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @cpuguy83 (test author) @duglin

integ-cli: skip test assuming -H is unix://...
`TestCliProxyDisableProxyUnixSock` verifies that HTTP_PROXY env var is
used when DOCKER_HOST is not set and cli connects to `unix://...` by
default.

In the windows/darwin CLI CIs, daemon is on remote host and we always
connect via `tcp://`, therefore this test fails very straight. Skipping
this test to run only on "same host daemon" assumption.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@tiborvass

This comment has been minimized.

Collaborator

tiborvass commented Mar 7, 2015

LGTM

@LK4D4

This comment has been minimized.

Contributor

LK4D4 commented Mar 9, 2015

LGTM

LK4D4 added a commit that referenced this pull request Mar 9, 2015

Merge pull request #11216 from ahmetalpbalkan/win-cli/TestCliProxyDis…
…ableProxyUnixSock-fix

integ-cli: skip test assuming -H is unix://...

@LK4D4 LK4D4 merged commit 057c5e6 into moby:master Mar 9, 2015

1 check passed

janky Jenkins build Docker-PRs 2718 has succeeded
Details

@ahmetb ahmetb deleted the ahmetb:win-cli/TestCliProxyDisableProxyUnixSock-fix branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment