integ-cli: use httpserver container for fakeGIT

[ahmetb]

This change enables fakeGIT() to use the new fakeStorage() server (#10893)
which is automatically starting a container on the remote test daemon machine
using the git repo directory.

Fixes the following tests:

• TestBuildApiLowerDockerfile
• TestBuildApiBuildGitWithF
• TestBuildApiDoubleDockerfile (skipped on windows: NTFS case-insensitive)
• TestBuildWithGIT (requires local http server)

These tests are currently failing because we're starting the fakeGIT server on
the same host with the CLI; not the test daemon.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com

[LK4D4]

@ahmetalpbalkan What's with windows build? Why library/httpserver is not found?

[ahmetb]

@LK4D4 it happens when .ensure-httpserver fails, most likely go compiler wasn't bootstrapped for linux/amd64 on the windows CI machine back then. looks better now?

[ahmetb]

ping @icecrime @tiborvass @duglin

[tiborvass]

LGTM

[jessfraz]

still see

--- FAIL: TestBuildApiLowerDockerfile (0.14s)
    docker_api_containers_test.go:390: error trying to add files to repo: exit status 128 (fatal: pathspec '*' did not match any files
        )
=== RUN TestBuildApiBuildGitWithF
--- FAIL: TestBuildApiBuildGitWithF (0.17s)
    docker_api_containers_test.go:415: error trying to add files to repo: exit status 128 (fatal: pathspec '*' did not match any files
        )

https://jenkins.dockerproject.com/job/Windows-PRs/120/console

[ahmetb]

@jfrazelle aware. I cannot repro locally 😞

[jessfraz]

ya im trying hehe

[jessfraz]

probably because * is intepreted weirdly by sh maybe @tianon has ideas

[jessfraz]

i figured it out, effing sh version

[jessfraz]

passed https://jenkins.dockerproject.com/job/Windows-PRs/123/console LGTM

[jessfraz]

=== RUN TestBuildApiLowerDockerfile
[PASSED]: container REST API - check build with lower dockerfile
--- PASS: TestBuildApiLowerDockerfile (29.99s)
=== RUN TestBuildApiBuildGitWithF
[PASSED]: container REST API - check build from git w/F
--- PASS: TestBuildApiBuildGitWithF (27.05s)
=== RUN TestBuildApiDoubleDockerfile
--- SKIP: TestBuildApiDoubleDockerfile (0.00s)
    requirements.go:87: Test requires posix utilities or functionality to run.
=== RUN TestBuildApiDockerfileSymlink
[PASSED]: container REST API - check build w/bad Dockerfile symlink path
--- PASS: TestBuildApiDockerfileSymlink (0.12s)

[ahmetb]

Wow how did that happen @jfrazelle

[jessfraz]

i blame clippy

On Wed, Mar 11, 2015 at 6:41 PM, Ahmet Alp Balkan notifications@github.com
wrote:

Wow how did that happen @jfrazelle https://github.com/jfrazelle

—
Reply to this email directly or view it on GitHub
#11278 (comment).