Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make utils_daemon and volumes.go cross-platform compileable (Windows). #11323
I have refactored the IsFileOwner function in utils_daemon to use system.GetStat and the cross-platform Stat type instead of (*syscall.Stat_t) (which does not exist on Windows). This change makes it possible to compile this file for Windows. However, GetStat will always return an error on Windows, because it is not implemented yet.
I have also added a test for the IsFileOwner function.
changed the title from
Make utils_daemon cross-platform compileable (Windows).
Make utils_daemon and volumes.go cross-platform compileable (Windows).
Mar 12, 2015
This is going to cause a few problems with the refactoring I've done in microsoft/docker for the Windows daemon port where I implement system.stat and system.lstat for Windows. PRs will be in the pipeline for these in the coming week or so.... I'll probably have to be undoing some of these changes with those PRs.
I feel like this PR is small enough to merge (and we encourage contributors to send multiple small patches rather than big ones) and the rebase should not be that painful either.
I'll let @icecrime decide though :)
Considering @gewoonrik has been actively following on this PR and reactive to people comments, I would be embarrassed to hold it because of upcoming PRs.
LGTM, pushing to