New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes `directory` pkg compilable on Windows. #11350

Merged
merged 1 commit into from Mar 13, 2015

Conversation

Projects
None yet
6 participants
@RickWieman
Contributor

RickWieman commented Mar 12, 2015

Also makes the test cases for directory platform independent.

Please note that I removed the part that follows hard links for the Windows implementation, as this was a Linux system call. I don't know if there exists a similar command for Windows.

Makes directory pkg compilable on Windows.
Also makes the test cases platform independent.

Signed-off-by: Rick Wieman <git@rickw.nl>
@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael

crosbymichael Mar 12, 2015

Contributor

LGTM

Contributor

crosbymichael commented Mar 12, 2015

LGTM

var err error
if err = os.Mkdir("/tmp/testSizeEmptyDirectory", 0777); err != nil {
if dir, err = ioutil.TempDir(os.TempDir(), "testSizeEmptyDirectory"); err != nil {

This comment has been minimized.

@icecrime

icecrime Mar 13, 2015

Contributor

That's really a detail, but you can give TempDir an empty string as first argument and let him figure out the default.

@icecrime

icecrime Mar 13, 2015

Contributor

That's really a detail, but you can give TempDir an empty string as first argument and let him figure out the default.

@icecrime

This comment has been minimized.

Show comment
Hide comment
@icecrime

icecrime Mar 13, 2015

Contributor

LGTM

Contributor

icecrime commented Mar 13, 2015

LGTM

icecrime pushed a commit that referenced this pull request Mar 13, 2015

Arnaud Porterie
Merge pull request #11350 from delftswa2014/utils-directory-windows
Makes `directory` pkg compilable on Windows.

@icecrime icecrime merged commit 6374c12 into moby:master Mar 13, 2015

2 checks passed

janky Jenkins build Docker-PRs 3205 has succeeded
Details
windows Jenkins build Windows-PRs 236 has succeeded
Details

@vieux vieux removed the status/4-merge label Mar 13, 2015

@RickWieman RickWieman deleted the delftswa2014:utils-directory-windows branch Mar 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment