Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow a non-existent groupid to own the docker socket #11377
Conversation
GordonTheTurtle
added
the
status/0-triage
label
Mar 13, 2015
This comment has been minimized.
This comment has been minimized.
|
+1 and the change LGTM |
This comment has been minimized.
This comment has been minimized.
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Mar 14, 2015
jessfraz
merged commit 649d833
into
moby:master
Mar 14, 2015
1 check passed
janky
Jenkins build Docker-PRs 3271 has succeeded
Details
vieux
removed
the
status/0-triage
label
Mar 14, 2015
jessfraz
added
the
status/2-code-review
label
Mar 14, 2015
aidanhs
deleted the
aidanhs:aphs-allow-nonexistent-gid
branch
Mar 14, 2015
aidanhs
referenced this pull request
Mar 14, 2015
Merged
Correctly check that gid parses as an int #11389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
aidanhs commentedMar 13, 2015
Workaround for #1715 - I've got an LDAP system which contains the group I want to use. It has a consistent gid so I'd like to be able to forcibly set the group id of the socket.
A group name can't be a valid parseable uint, so this check will only take effect when someone's trying to set a group id explicitly. I think it's a safe assumption that someone trying to set a group id explicitly knows what they're doing.