Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ANSI emulation in certain windows shells #11648

Merged
merged 1 commit into from Mar 23, 2015
Merged

Disable ANSI emulation in certain windows shells #11648

merged 1 commit into from Mar 23, 2015

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Mar 23, 2015

This disables recently added ANSI emulation feature in certain Windows
shells (like ConEmu) where ANSI output is emulated by default with builtin
functionality in the shell.

MSYS (mingw) runs in cmd.exe window and it doesn't support emulation.

Cygwin doesn't even pass terminal handles to docker.exe as far as I can
tell, stdin/stdout/stderr handles are behaving like non-TTY. Therefore not
even including that in the check.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @sachin-jayant-joshi @tiborvass @icecrime

This disables recently added ANSI emulation feature in certain Windows
shells (like ConEmu) where ANSI output is emulated by default with builtin
functionality in the shell.

MSYS (mingw) runs in cmd.exe window and it doesn't support emulation.

Cygwin doesn't even pass terminal handles to docker.exe as far as I can
tell, stdin/stdout/stderr handles are behaving like non-TTY. Therefore not
even including that in the check.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Mar 23, 2015

do we need this for 1.6

@jessfraz jessfraz added this to the 1.6.0 milestone Mar 23, 2015
@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Mar 23, 2015

@jfrazelle yes yes yes that'd be super nice. if things go horribly wrong people this code will behave like a security switch and when people use ConEmu shell, the new windows ANSI term code recently merged won't be called at all.

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Mar 23, 2015

code changes LGTM just waiting on janky

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Mar 23, 2015

we can ignore the TestPullVerified failure

@cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Mar 23, 2015

I don't have a system to test on, but code LGTM

jessfraz pushed a commit that referenced this issue Mar 23, 2015
…check

Disable ANSI emulation in certain windows shells
@jessfraz jessfraz merged commit b094677 into moby:master Mar 23, 2015
1 of 2 checks passed
@ahmetb ahmetb deleted the win-cli/ansi-emulation-check branch Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants