New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ANSI emulation in certain windows shells #11648

Merged
merged 1 commit into from Mar 23, 2015

Conversation

Projects
None yet
4 participants
@ahmetb
Contributor

ahmetb commented Mar 23, 2015

This disables recently added ANSI emulation feature in certain Windows
shells (like ConEmu) where ANSI output is emulated by default with builtin
functionality in the shell.

MSYS (mingw) runs in cmd.exe window and it doesn't support emulation.

Cygwin doesn't even pass terminal handles to docker.exe as far as I can
tell, stdin/stdout/stderr handles are behaving like non-TTY. Therefore not
even including that in the check.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @sachin-jayant-joshi @tiborvass @icecrime

Disable ANSI emulation in certain windows shells
This disables recently added ANSI emulation feature in certain Windows
shells (like ConEmu) where ANSI output is emulated by default with builtin
functionality in the shell.

MSYS (mingw) runs in cmd.exe window and it doesn't support emulation.

Cygwin doesn't even pass terminal handles to docker.exe as far as I can
tell, stdin/stdout/stderr handles are behaving like non-TTY. Therefore not
even including that in the check.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Mar 23, 2015

do we need this for 1.6

@jessfraz jessfraz added this to the 1.6.0 milestone Mar 23, 2015

@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Mar 23, 2015

@jfrazelle yes yes yes that'd be super nice. if things go horribly wrong people this code will behave like a security switch and when people use ConEmu shell, the new windows ANSI term code recently merged won't be called at all.

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Mar 23, 2015

code changes LGTM just waiting on janky

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Mar 23, 2015

we can ignore the TestPullVerified failure

@cpuguy83

This comment has been minimized.

Contributor

cpuguy83 commented Mar 23, 2015

I don't have a system to test on, but code LGTM

jessfraz pushed a commit that referenced this pull request Mar 23, 2015

Jessie Frazelle
Merge pull request #11648 from ahmetalpbalkan/win-cli/ansi-emulation-…
…check

Disable ANSI emulation in certain windows shells

@jessfraz jessfraz merged commit b094677 into moby:master Mar 23, 2015

1 of 2 checks passed

windows Jenkins build Windows-PRs 988 has failed
Details
janky Jenkins build Docker-PRs 3986 has succeeded
Details

@ahmetb ahmetb deleted the ahmetb:win-cli/ansi-emulation-check branch Mar 23, 2015

@surfjedi surfjedi referenced this pull request Mar 26, 2015

Closed

Do not display empty TOC #5288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment