Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap width/height in GetWinsize and monitorTtySize #12127

Merged
merged 1 commit into from Apr 6, 2015
Merged

Swap width/height in GetWinsize and monitorTtySize #12127

merged 1 commit into from Apr 6, 2015

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Apr 6, 2015

Fixing code lost in translation

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
Emergency cc: @icecrime @jfrazelle @calavera @brendandixon

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 6, 2015

you rule

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 6, 2015

omg its beautiful LGTM

@jessfraz jessfraz added this to the 1.6.0 milestone Apr 6, 2015
@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 6, 2015

@icecrime
Copy link
Contributor

@icecrime icecrime commented Apr 6, 2015

Testing!

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 6, 2015

I tried ls, vim , top and now im trying nyancat in conemu

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 6, 2015

btw i put the binary here if you wanna try http://jesss.s3.amazonaws.com/tmp/docker-1.5.0-dev.exe

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Apr 6, 2015

Width: uint16(info.Window.Bottom - info.Window.Top + 1),
Height: uint16(info.Window.Right - info.Window.Left + 1),
Width: uint16(info.Window.Right - info.Window.Left + 1),
Height: uint16(info.Window.Bottom - info.Window.Top + 1),
Copy link
Contributor

@icecrime icecrime Apr 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those + 1 might be wrong: if I run an interactive session and sleep on the a key, it wraps one character "too late", and gives me empty lines. Behavior is correct without the +1.

Copy link
Contributor Author

@ahmetb ahmetb Apr 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @brendandixon @jhowardmsft about this off by one

Copy link
Member

@lowenna lowenna Apr 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wrapping should be solved by microsoft@7c83ec1 which @brendandixon or @ahmetalpbalkan where going to open a PR for.

@icecrime
Copy link
Contributor

@icecrime icecrime commented Apr 6, 2015

Question regarding the + 1 offset, otherwise LGTM 👍

jessfraz pushed a commit that referenced this issue Apr 6, 2015
Swap width/height in GetWinsize and monitorTtySize
@jessfraz jessfraz merged commit 9ede3f9 into moby:master Apr 6, 2015
2 checks passed
@ahmetb ahmetb deleted the win-cli/termsize-fix branch Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants