Swap width/height in GetWinsize and monitorTtySize #12127
Conversation
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
you rule |
|
omg its beautiful LGTM |
|
ping @icecrime @tiborvass |
|
Testing! |
|
I tried ls, vim , top and now im trying nyancat in conemu |
|
btw i put the binary here if you wanna try http://jesss.s3.amazonaws.com/tmp/docker-1.5.0-dev.exe |
|
https://s3.j3ss.co/screenshots/2015-04-06-15-09-38_2560x2520.png docker run --rm -it supertest2014/nyan |
| Width: uint16(info.Window.Bottom - info.Window.Top + 1), | ||
| Height: uint16(info.Window.Right - info.Window.Left + 1), | ||
| Width: uint16(info.Window.Right - info.Window.Left + 1), | ||
| Height: uint16(info.Window.Bottom - info.Window.Top + 1), |
There was a problem hiding this comment.
I think those + 1 might be wrong: if I run an interactive session and sleep on the a key, it wraps one character "too late", and gives me empty lines. Behavior is correct without the +1.
There was a problem hiding this comment.
cc: @brendandixon @jhowardmsft about this off by one
There was a problem hiding this comment.
That wrapping should be solved by microsoft@7c83ec1 which @brendandixon or @ahmetalpbalkan where going to open a PR for.
|
Question regarding the |
Swap width/height in GetWinsize and monitorTtySize
Fixing code lost in translation
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
Emergency cc: @icecrime @jfrazelle @calavera @brendandixon