New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unsupported instructions in the docs. #12536

Merged
merged 1 commit into from Apr 21, 2015

Conversation

Projects
None yet
6 participants
@mountkin
Contributor

mountkin commented Apr 20, 2015

The 'supported Dockerfile instructions' in the references and man pages for docker commit and docker import is incorrect according to https://github.com/docker/docker/blob/master/builder/job.go#L28

Signed-off-by: Shijiang Wei mountkin@gmail.com

Remove some unsupported instructions in the docs.
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
@estesp

This comment has been minimized.

Contributor

estesp commented Apr 20, 2015

ping @duglin for tech review this is correct

@duglin

This comment has been minimized.

Contributor

duglin commented Apr 21, 2015

LGTM
ping @moxiegirl @fredlf

@moxiegirl

This comment has been minimized.

Contributor

moxiegirl commented Apr 21, 2015

LGTM

1 similar comment
@fredlf

This comment has been minimized.

Contributor

fredlf commented Apr 21, 2015

LGTM

fredlf pushed a commit that referenced this pull request Apr 21, 2015

Fred Lifton
Merge pull request #12536 from mountkin/remove-unsupported-instructio…
…ns-from-doc

Remove some unsupported instructions in the docs.

@fredlf fredlf merged commit 21c8d21 into moby:master Apr 21, 2015

3 checks passed

docker/dco-signed All commits signed
Details
janky Jenkins build Docker-PRs 6167 has succeeded
Details
windows Jenkins build Windows-PRs 3137 has succeeded
Details

@mountkin mountkin deleted the mountkin:remove-unsupported-instructions-from-doc branch Oct 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment