New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add Logging driver for fluentd #12540

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
@tagomoris
Contributor

tagomoris commented Apr 20, 2015

I think that some more Logging driver make users happy!
This is the first for more logging drivers for Fluentd.

See the files for more details.

Add proposal of Logging driver for fluentd
Signed-off-by: TAGOMORI Satoshi <tagomoris@gmail.com>

@GordonTheTurtle GordonTheTurtle added dco/yes and removed dco/no labels Apr 20, 2015

@kysnm

This comment has been minimized.

Show comment
Hide comment
@kysnm

kysnm commented Apr 22, 2015

👍

8 similar comments
@ijin

This comment has been minimized.

Show comment
Hide comment
@ijin

ijin commented Apr 22, 2015

👍

@katutoshi

This comment has been minimized.

Show comment
Hide comment
@katutoshi

katutoshi commented Apr 22, 2015

👍

@zchee

This comment has been minimized.

Show comment
Hide comment
@zchee

zchee Apr 22, 2015

Contributor

👍

Contributor

zchee commented Apr 22, 2015

👍

@kazegusuri

This comment has been minimized.

Show comment
Hide comment
@kazegusuri

kazegusuri commented Apr 22, 2015

👍

@ixixi

This comment has been minimized.

Show comment
Hide comment
@ixixi

ixixi commented Apr 22, 2015

👍

@Saisse

This comment has been minimized.

Show comment
Hide comment
@Saisse

Saisse commented Apr 22, 2015

👍

@otaki-ryuta

This comment has been minimized.

Show comment
Hide comment
@otaki-ryuta

otaki-ryuta commented Apr 22, 2015

👍

@tmtk75

This comment has been minimized.

Show comment
Hide comment
@tmtk75

tmtk75 commented Apr 22, 2015

👍

@icecrime icecrime removed the dco/yes label Apr 23, 2015

@jessfraz

This comment has been minimized.

Show comment
Hide comment
@jessfraz

jessfraz Apr 24, 2015

Contributor

hey all we get it you want this, but can you not +1, because it makes feedback hard to read :), we promise we will do our best to review this as soon as possible

Contributor

jessfraz commented Apr 24, 2015

hey all we get it you want this, but can you not +1, because it makes feedback hard to read :), we promise we will do our best to review this as soon as possible

@jessfraz

This comment has been minimized.

Show comment
Hide comment
@jessfraz

jessfraz Apr 24, 2015

Contributor

adding this seems fine to me, will wait for others to approve then we can move into code-review if so :)

Contributor

jessfraz commented Apr 24, 2015

adding this seems fine to me, will wait for others to approve then we can move into code-review if so :)

@kzk

This comment has been minimized.

Show comment
Hide comment
@kzk

kzk Apr 29, 2015

@jfrazelle Just a background. @tagomoris is a maintainer of Fluentd (http://www.fluentd.org/), and I'm from Treasure Data, Inc. sponsoring Fluentd project.

Docker + Fluentd adopted by Google & Kubernetes

We recently started seeing more people adopting Docker + Fluentd. For example. Google's Kubernetes adopted Fluentd as a default log collector. But Kubernetes uses Fluentd's 'tail' input plugin for log files. It's not performant, reliable, and config files become relatively messy...

FYI: Google adopted Fluentd as a default log collector for the entire cloud platform (packaging repo, bigquery documentation).

Docker + Fluentd by Digital Ocean

Digital Ocean wrote a documentation about how to centralize Docker logs into one place, using Fluentd. But as I mentioned above, it tails log files as well.

Push logs directly from Docker to Fluentd (Code is available)

We'd like to have a way to directly push the logs from Docker to Fluentd, which is more performant, reliable, and simple. Just in case, @tagomoris already wrote a code so that you can review.

Logging is the essential part of the immutable infrastructure, so hope Docker has a flexible way to centralized logs using the solution like Fluentd.

kzk commented Apr 29, 2015

@jfrazelle Just a background. @tagomoris is a maintainer of Fluentd (http://www.fluentd.org/), and I'm from Treasure Data, Inc. sponsoring Fluentd project.

Docker + Fluentd adopted by Google & Kubernetes

We recently started seeing more people adopting Docker + Fluentd. For example. Google's Kubernetes adopted Fluentd as a default log collector. But Kubernetes uses Fluentd's 'tail' input plugin for log files. It's not performant, reliable, and config files become relatively messy...

FYI: Google adopted Fluentd as a default log collector for the entire cloud platform (packaging repo, bigquery documentation).

Docker + Fluentd by Digital Ocean

Digital Ocean wrote a documentation about how to centralize Docker logs into one place, using Fluentd. But as I mentioned above, it tails log files as well.

Push logs directly from Docker to Fluentd (Code is available)

We'd like to have a way to directly push the logs from Docker to Fluentd, which is more performant, reliable, and simple. Just in case, @tagomoris already wrote a code so that you can review.

Logging is the essential part of the immutable infrastructure, so hope Docker has a flexible way to centralized logs using the solution like Fluentd.

@Zaki-XL

This comment has been minimized.

Show comment
Hide comment
@Zaki-XL

Zaki-XL commented Apr 29, 2015

👍

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Apr 29, 2015

Contributor

Definitely +1 as long as we can ping for issues. @tagomoris @kzk do you plan to contribute code for this?
Also, proposal doc is probably longer than the actual implementation will be :)

Contributor

cpuguy83 commented Apr 29, 2015

Definitely +1 as long as we can ping for issues. @tagomoris @kzk do you plan to contribute code for this?
Also, proposal doc is probably longer than the actual implementation will be :)

@tagomoris

This comment has been minimized.

Show comment
Hide comment
@tagomoris

tagomoris Apr 29, 2015

Contributor

I already have a complete code for this feature.
So I've just created a pull request #12876.

Contributor

tagomoris commented Apr 29, 2015

I already have a complete code for this feature.
So I've just created a pull request #12876.

@jessfraz

This comment has been minimized.

Show comment
Hide comment
@jessfraz

jessfraz Apr 29, 2015

Contributor

can you then combine this with that one so there are not two threads for the same feature and close this one

Contributor

jessfraz commented Apr 29, 2015

can you then combine this with that one so there are not two threads for the same feature and close this one

@kzk

This comment has been minimized.

Show comment
Hide comment
@kzk

kzk Apr 29, 2015

@cpuguy83 I can give you our point of contacts for you. Please reach out to me at k@treasure-data.com. Of course just mentioning on github works too.

kzk commented Apr 29, 2015

@cpuguy83 I can give you our point of contacts for you. Please reach out to me at k@treasure-data.com. Of course just mentioning on github works too.

@LK4D4

This comment has been minimized.

Show comment
Hide comment
@LK4D4

LK4D4 May 12, 2015

Contributor

I think we can close this, because now it is real PR #12876

Contributor

LK4D4 commented May 12, 2015

I think we can close this, because now it is real PR #12876

@LK4D4 LK4D4 closed this May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment