New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag option to syslog #12668

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@ibuildthecloud
Contributor

ibuildthecloud commented Apr 23, 2015

Note: This PR is based off of #12422. Both this and that PR need to be rebased

Currently the syslog tag is the container ID. This PR allows the user to specify any value for the tag. More context in #12391

@ibukanov

This comment has been minimized.

ibukanov commented Apr 28, 2015

It is more useful to allow to specify not a tag but a pattern or template that can refer to container id and name so both can present in logs.

@tlunter

This comment has been minimized.

Contributor

tlunter commented May 6, 2015

Would really love an option like this!

@ibuildthecloud

This comment has been minimized.

Contributor

ibuildthecloud commented May 7, 2015

@LK4D4 any chance you can review this. The design is based on your suggestions.

@thaJeztah

This comment has been minimized.

Member

thaJeztah commented May 10, 2015

@ibuildthecloud #12422 was merged, can you rebase this PR?

@ibuildthecloud

This comment has been minimized.

Contributor

ibuildthecloud commented May 10, 2015

Will do, thanks

Add tag option to syslog driver
Signed-off-by: Darren Shepherd <darren@rancher.com>

@ibuildthecloud ibuildthecloud force-pushed the ibuildthecloud:syslog-tag branch from 903ecf2 to 6a74b6f May 11, 2015

@terbooter

This comment has been minimized.

terbooter commented May 18, 2015

Very useful feature!

@runcom

This comment has been minimized.

Member

runcom commented May 21, 2015

@ibuildthecloud could you please rebase this due to #12422 is now merged? also this will be kinda related to #13362

@thaJeztah

This comment has been minimized.

Member

thaJeztah commented May 21, 2015

@runcom and (at least, I suggested), related to #12876, because that PR also has a way to specify the "tag" for logging. Would be nice to have a consistent UX for defining the tag among the various log-drivers

@runcom

This comment has been minimized.

Member

runcom commented May 21, 2015

@thaJeztah thanks for pointing to that, will keep that in mind. Now just wait @ibuildthecloud to rebase because many things changed here. And btw yes, would be cool to have something just for the tag option because other -log-opt are needed for other thinghies such as defining network hosts, ports etc etc per log driver

@thaJeztah

This comment has been minimized.

Member

thaJeztah commented May 21, 2015

I still think it's good to define via --log-opt, just that if it's done that way, it would be nice if all drivers used the same convention (where possible). I don't think a dedicated flag should be added just for the 'tag'.

@LK4D4

This comment has been minimized.

Contributor

LK4D4 commented Jun 2, 2015

@ibuildthecloud I'll carry this for you. Thanks for work! Sorry for all that bikeshedding.

@LK4D4 LK4D4 referenced this pull request Jun 2, 2015

Merged

Add syslog-tag option #13672

@sdorra sdorra referenced this pull request Oct 20, 2015

Closed

use docker syslog driver #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment