Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Arch Linux ARM base images generation (#16695). #16704

Merged
merged 1 commit into from
Jan 6, 2016
Merged

Add support for Arch Linux ARM base images generation (#16695). #16704

merged 1 commit into from
Jan 6, 2016

Conversation

manchoz
Copy link
Contributor

@manchoz manchoz commented Oct 1, 2015

Implementation of feature request #16695.

Signed-off-by: Giampaolo Mancini giampaolo@trampolineup.com

@GordonTheTurtle GordonTheTurtle added status/0-triage dco/no Automatically set by a bot when one of the commits lacks proper signature labels Oct 1, 2015
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Oct 1, 2015
@thaJeztah
Copy link
Member

/cc @DieterReuter because I think you're working on these things as well 😄

@manchoz
Copy link
Contributor Author

manchoz commented Oct 29, 2015

Note that contrib/mkimage.sh is already able to build Debian-based "armhf" base images for ARM machines.

Just run mkimage.sh as usual from an ARM machine (RPi, BeagleBone, Scaleway C1 servers, etc.) :-)

My patch is intended for building Arch Linux-based ARM base images.

@thaJeztah
Copy link
Member

Ah, you're right, I was browsing quickly through PRs, didn't look in-depth 👍

@manchoz
Copy link
Contributor Author

manchoz commented Oct 30, 2015

Nonetheless @DieterReuter opinions and contributions would be welcome! Thanks for cc-ing, @thaJeztah!

@DieterReuter
Copy link
Contributor

@manchoz Just a few notes. For Arch Linux there are armv6h and armv7h supported in the archarm package repo. But you're using only the armv7h repo.

@manchoz
Copy link
Contributor Author

manchoz commented Oct 31, 2015

Ok. I will look for adding support for armv6h and more prerequisites checks in next commits. Thanks @DieterReuter!

@LK4D4
Copy link
Contributor

LK4D4 commented Nov 13, 2015

@manchoz Any news here? Is it ready for review?

@manchoz
Copy link
Contributor Author

manchoz commented Nov 17, 2015

Hi @LK4D4, let me push some update and it will be ready.

@thaJeztah
Copy link
Member

ping @manchoz looks like it needs a rebase as well; did you push those updates?

@manchoz
Copy link
Contributor Author

manchoz commented Dec 9, 2015

@thaJeztah just pushed.

Won't add support for armv6 Arch Linux because there are just very few and very old armv6 machines supported by Arch Linux ARM (mainly first generation RPi).

@thaJeztah
Copy link
Member

@manchoz looks like there are still merge conflicts 😢

@manchoz
Copy link
Contributor Author

manchoz commented Dec 11, 2015

@thaJeztah it seems that the userns build timed-out: would you mind to rerun? Thanks!

@thaJeztah
Copy link
Member

@manchoz I restarted it

@thaJeztah
Copy link
Member

All green again!

@thaJeztah
Copy link
Member

ping @tianon @jfrazelle could you have a look please?

also @DieterReuter happy to hear if this LGTY

@DieterReuter
Copy link
Contributor

LGTM

@jessfraz
Copy link
Contributor

Can you squash the commits please

On Friday, December 11, 2015, Dieter Reuter notifications@github.com
wrote:

LGTM

—
Reply to this email directly or view it on GitHub
#16704 (comment).

@GordonTheTurtle GordonTheTurtle added the dco/no Automatically set by a bot when one of the commits lacks proper signature label Dec 11, 2015
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Dec 11, 2015
@manchoz
Add support for Arch Linux ARM. (Close moby#16695)
824ae85 
Signed-off-by: Giampaolo Mancini <giampaolo@trampolineup.com>

Switch to "case"

Signed-off-by: Giampaolo Mancini <giampaolo@trampolineup.com>

Support multiple ARM architectures

Signed-off-by: Giampaolo Mancini <giampaolo@trampolineup.com>

Add check for ArchLinuxARM Keyring

Signed-off-by: Giampaolo Mancini <giampaolo@trampolineup.com>

mkimage-arch.sh: Fix for merging

Signed-off-by: Giampaolo Mancini <giampaolo@trampolineup.com>
@thaJeztah
Copy link
Member

ping @jfrazelle @tianon commits are squashed. ptal

@jessfraz
Copy link
Contributor

LGTM

@manchoz
Copy link
Contributor Author

manchoz commented Dec 15, 2015

Thanks everyone @jfrazelle @thaJeztah @tianon

@thaJeztah
Copy link
Member

ping @tianon could you have a look at this one? I think it's ready to merge, just final check from you! ❤️

tianon
tianon reviewed Dec 16, 2015
View reviewed changes
contrib/mkimage-archarm-pacman.conf
#XferCommand = /usr/bin/wget --passive-ftp -c -O %o %u
#CleanMethod = KeepInstalled
#UseDelta = 0.7
Architecture = armv7h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean this file will only work on armv7? Doesn't Arch support other ARM arches?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianon Yes, it will work only in/for armv7. Arch Linux ARM supports also other ARM architectures (v5, v6 and v8) but as noted in #16704 (comment), other arches support only very old SBCs (which i'm not sure if docker would be able to run on).

Adding support for other arches would be very easy and can be done in two ways:

  • Adding a pacman.conf for every arch we would like to support
  • Modifing the mkimage-arch.sh script to detect arch and generate the right pacman.conf file at runtime.

Let me know if you would like to add support for other arches and which method you would like the best.

Copy link
Member

@tianon tianon Dec 22, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @manchoz can you have a look at @tianon's suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @thaJeztah, I will do the requested changes next days.

@icecrime
Copy link
Contributor

icecrime commented Jan 6, 2016

I'm merging as it's been opened for a while, @jfrazelle will fix the %ARCH% in a followup PR.

Thanks!

icecrime pushed a commit that referenced this pull request Jan 6, 2016
Merge pull request #16704 from manchoz/16695_manchoz_archarm
837de95 
Add support for Arch Linux ARM base images generation (#16695).
@icecrime icecrime merged commit 837de95 into moby:master Jan 6, 2016
@manchoz manchoz deleted the 16695_manchoz_archarm branch January 8, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jessfraz jessfraz

Labels
status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@manchoz @thaJeztah @DieterReuter @LK4D4 @jessfraz @icecrime @tianon @GordonTheTurtle