Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging driver for Google Cloud Logging #18766

Merged
merged 2 commits into from Mar 2, 2016
Merged

Conversation

@mikedanese
Copy link
Contributor

@mikedanese mikedanese commented Dec 18, 2015

@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch 6 times, most recently from 33062d9 to 5a1cc9e Dec 18, 2015
@mikedanese mikedanese closed this Dec 18, 2015
@mikedanese mikedanese reopened this Dec 18, 2015
@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch 4 times, most recently from 560b598 to 022e8dc Dec 18, 2015
@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Dec 30, 2015

@vdemeester how do i get a design review on this patch set?

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 30, 2015

@mikedanese apologies for the delay, I'll see if there's a maintainer to review soon, but that may be next week due to New Year, and some maintainers having some days off for the holidays and new year.

@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Dec 31, 2015

Thanks @thaJeztah, no worries.

@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Jan 13, 2016

@thaJeztah Is anyone able to review this yet?

@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Jan 24, 2016

@thaJeztah @vdemeester is there any recommendation on how I can move this forward?

@icecrime
Copy link
Contributor

@icecrime icecrime commented Jan 26, 2016

That's a lot of dependencies.. ;-)

LGTM, WDYT @LK4D4?

@thaJeztah thaJeztah added this to the 1.11.0 milestone Jan 26, 2016
@icecrime
Copy link
Contributor

@icecrime icecrime commented Feb 2, 2016

@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch 2 times, most recently from d0ec6a1 to 49e1c7d Feb 2, 2016
}

// we start dropping logs at 10,000 log lines per second.
c.Overflow = func(_ *logging.Client, _ logging.Entry) error {

This comment has been minimized.

@LK4D4

LK4D4 Feb 3, 2016
Contributor

I don't fully understand what does it mean. Do we log errors only once in 1000 dropped messages? What comment means?

This comment has been minimized.

@mikedanese

mikedanese Feb 3, 2016
Author Contributor

The logger "overflows" at a rate of 10,000 logs per second (but could be configured higher or lower) and this overflow func is called. I'm looking for a way to surface the error to the user. Currently it logs an error once every 1000 messages. If i log every message it spams /var/log/docker.log. I could log at most once every 5 seconds or I could ignore these logs.

This comment has been minimized.

@mikedanese

mikedanese Feb 5, 2016
Author Contributor

@LK4D4 Would you prefer I change this to work someway else?

This comment has been minimized.

@LK4D4

LK4D4 Feb 5, 2016
Contributor

No, it's ok, but better to put your answer in comment.

@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch from 49e1c7d to 96b2900 Feb 6, 2016
@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Feb 6, 2016

@icecrime @LK4D4 I've updated the comment.

@@ -207,6 +208,7 @@ __docker_get_log_options() {
syslog_options=("syslog-address" "syslog-tls-ca-cert" "syslog-tls-cert" "syslog-tls-key" "syslog-tls-skip-verify" "syslog-facility" "tag")
splunk_options=("env" "labels" "splunk-caname" "splunk-capath" "splunk-index" "splunk-insecureskipverify" "splunk-source" "splunk-sourcetype" "splunk-token" "splunk-url" "tag")

[[ $log_driver = (gcplogs|all) ]] && _describe -t gcplogs-options "gcplogs options" gcplogs_options "$@" && ret=0

This comment has been minimized.

@sdurrheimer

sdurrheimer Feb 18, 2016
Contributor

nit: same here alphabetical order

@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch from e9ddc3f to b82a3a2 Feb 22, 2016
@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Feb 22, 2016

Thanks for the review @thaJeztah @albers @sdurrheimer. I've append a commit that addresses the comments.

@albers
Copy link
Member

@albers albers commented Feb 23, 2016

The log-cmd option seems to be driver specific, so maybe it should be renamed to gcp-log-cmd.

@albers
Copy link
Member

@albers albers commented Feb 23, 2016

bash completion is perfect, thanks very much! LGTM (IANAM)

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 23, 2016

The log-cmd option seems to be driver specific, so maybe it should be renamed to tcp-log-cmd.

Good suggestion if it's specific to this driver

I'll check the docs later

The added dependencies are:
* golang.org/x/oauth2
* google.golang.org/api
* google.golang.org/cloud

Signed-off-by: Mike Danese <mikedanese@google.com>
@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch from b82a3a2 to e77b826 Feb 24, 2016
@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Feb 24, 2016

The log-cmd option seems to be driver specific, so maybe it should be renamed to tcp-log-cmd.

Done.

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 24, 2016

Thanks @mikedanese, last couple of nits, but we're almost there

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 29, 2016

ping @mikedanese can you update your PR?

Signed-off-by: Mike Danese <mikedanese@google.com>
@mikedanese mikedanese force-pushed the mikedanese:gcplogs branch from e77b826 to ed1b9fa Mar 1, 2016
@calavera
Copy link
Contributor

@calavera calavera commented Mar 1, 2016

@thaJeztah docs update LGTM, can you take a look?

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 1, 2016

Thanks @mikedanese sorry missed you updated the PR

tested the docs and LGTM!

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 1, 2016

restarted windowsTP4

@mikedanese
Copy link
Contributor Author

@mikedanese mikedanese commented Mar 1, 2016

@thaJeztah Just sent it out this morning. I was going to wait for ci to go green before pinging you :) Thanks for the review!

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 2, 2016

Oh, it's green now, merging!

thaJeztah added a commit that referenced this pull request Mar 2, 2016
Add logging driver for Google Cloud Logging
@thaJeztah thaJeztah merged commit 3c4d093 into moby:master Mar 2, 2016
9 checks passed
9 checks passed
@GordonTheTurtle
docker/dco-signed All commits signed
Details
@docker-jenkins
documentation success 2 tests run, 0 skipped, 0 failed.
Details
@GordonTheTurtle
experimental Jenkins build Docker-PRs-experimental 15645 has succeeded
Details
@GordonTheTurtle
gccgo Jenkins build Docker-PRs-gccgo 2543 has succeeded
Details
@GordonTheTurtle
janky Jenkins build Docker-PRs 24434 has succeeded
Details
@GordonTheTurtle
userns Jenkins build Docker-PRs-userns 6785 has succeeded
Details
@GordonTheTurtle
vendor Jenkins build Docker-PRs-vendor 306 has succeeded
Details
@GordonTheTurtle
win2lin Jenkins build Docker-PRs-Win2Lin 22549 has succeeded
Details
@GordonTheTurtle
windowsTP4 Jenkins build Docker-PRs-WoW-TP4 1871 has succeeded
Details
@mikedanese mikedanese deleted the mikedanese:gcplogs branch Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet