Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

936 enhanced logging #1991

Closed
wants to merge 92 commits into from

Conversation

Projects
None yet
@karlgrz
Copy link
Contributor

commented Sep 24, 2013

This begins to address issue #936, and exposes more error messages in the daemon as opposed to requiring you to run in debug (-D) mode.

@shykes

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2013

Thanks @karlgrz this seems useful. I'm afraid you need to rebase given the wide surface area of your patch... Then we should merge it quickly before it breaks again :)

/cc @crosbymichael @creack @vieux

@karlgrz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2013

No worries, I'll get on that.

Merge remote-tracking branch 'upstream/master'
into 936-enhanced-logging

Conflicts:
	api.go
	commands.go
	server.go
@karlgrz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2013

Ok, I've updated the merge conflicts I believe.

@vieux

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2013

LGTM

@shykes

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2013

@karlgrz could you squash and rebase? Also add yourself to AUTHORS if you haven't already. Then we're ready to merge. Thanks.

@karlgrz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2013

Ahhh yes, will do once I get back home.
On Oct 2, 2013 8:20 PM, "Solomon Hykes" notifications@github.com wrote:

@karlgrz https://github.com/karlgrz could you squash and rebase? Also
add yourself to AUTHORS if you haven't already. Then we're ready to merge.
Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1991#issuecomment-25590737
.

dsissitka and others added some commits Sep 26, 2013

automatically remove container via -rm
add AutoRemove to HostConfig
add -rm flag to docker run
add TestRunAutoRemove to test -rm
docs: add -rm to commandline/command/run
add hostConfig to container monitor
make monitor destroy the container via -rm

This adds support for automatically removing a container after it
exits. The removal of the container is handled on the server side.
Changes to a new style for the docs. Includes version switcher.
* added link to edit on GitHub
* Changed image source on homepage
* Made some changes to the structure, added the ability to have l3 navigation. Added warning, note and other styles.
* Fixed an image link, removed the .. :content: links because they were quicky and didn't look good, added pagelinks to current page of other versions.
* Moved the remote client api's to their own doc
Update ubuntu docs to use wget instead of curl
Ubuntu doesn't come with curl.

wget instead of curl

nicer wget syntax

remove /dev/null
Merge branch '936-enhanced-logging' of ssh://github.com/karlgrz/docke…
…r into 936-enhanced-logging

Conflicts:
	docs/sources/api/docker_remote_api.rst
	docs/sources/contributing/devenvironment.rst
@karlgrz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2013

Ugh...did not squash / rebase properly at all. My apologies. I will fix this up onto a new branch and new pull request later today. Sorry for the delay.

@karlgrz karlgrz closed this Oct 3, 2013

@karlgrz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2013

Opened new PR here: #2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.