Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile and hack to support compiling device-mapper code statically (using go1.2rc1) #2053

Closed
wants to merge 1 commit into from

Conversation

@tianon
Copy link
Member

tianon commented Oct 1, 2013

Lots of thanks to @creack for figuring out the hard parts via https://github.com/creack/docker_devmapper/blob/master/Dockerfile.

/cc @vieux @shykes @creack

Also, I've updated the packaging documentation in hack to reflect the newer requirements (hopefully didn't forget anything - so that needs more eyeballs on it).

@tianon

This comment has been minimized.

Copy link
Member Author

tianon commented Oct 1, 2013

Also, I made a few small spelling, grammar, and consistency fixes to hack/PACKAGERS.md while I was in there. Please let me know if there are more fixes I should include, more language that needs to be added, or especially dependencies that need to be updated in that document. I figure the bulk of the documentation updates will or have occurred separately (especially with regards to the kernel no longer requiring AUFS), and that this commit/PR should only include updates to the hack file that's relevant to them.

@alexlarsson

This comment has been minimized.

Copy link
Contributor

alexlarsson commented Oct 1, 2013

I've not really looked at these build scripts before, but it looks sane to me.

@vieux

This comment has been minimized.

Copy link
Contributor

vieux commented Oct 1, 2013

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Oct 1, 2013

I'm testing the go1.2 and build flags for statically compiling sqlite in my links branch. So far everything looks good as far as statically linking is concerned.

@ajf

This comment has been minimized.

Copy link

ajf commented Oct 2, 2013

This built just fine, however almost all of the tests fail with Error: Error starting container 818391894621: Unknown base hash without including the hash value, looks like from this section of code:

    baseInfo := devices.Devices[baseHash]
    if baseInfo == nil {
        return fmt.Errorf("Unknown base hash %s", baseHash)
    }

Not sure if it's related to some build process or if the branch is just broken for now.

@tianon

This comment has been minimized.

Copy link
Member Author

tianon commented Oct 2, 2013

Just as a status update for those following along at home, @creack is looking into solutions for our "Unknown base hash" issues.

@crosbymichael

This comment has been minimized.

Copy link
Member

crosbymichael commented Oct 9, 2013

@tianon I think this can be closed now because these changes have been integrated into the staging branch.

@tianon

This comment has been minimized.

Copy link
Member Author

tianon commented Oct 9, 2013

Indeed, good call.

@tianon tianon closed this Oct 9, 2013
@tianon tianon deleted the tianon:hack-build-device-mapper branch Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.