New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change validateNoSchema to validateNoScheme #21607
change validateNoSchema to validateNoScheme #21607
Conversation
63dd674
to
4bc9d10
Compare
|
@allencloud as @mlaventure said, the |
ping @allencloud can you update your PR and revert the changes in the |
@thaJeztah |
@allencloud you made a change in vendor/src/github.com/docker/distribution/registry/api/v2/urls.go, since that file is vendored (copied) from another repository, you shouldn't change those files; your change is here; https://github.com/docker/docker/pull/21607/files#diff-9560ef2430be0af7ce734cd21bdcc2ccR17 If you change that back, the "vendor" check will no longer fail |
2.change schema into scheme in docs and some annotations. Signed-off-by: allencloud <allen.sun@daocloud.io>
@thaJeztah |
4bc9d10
to
28d3c22
Compare
thanks! LGTM |
LGTM 🐮 |
validateNoSchema has a typo in func name.
It should be validateNoScheme.