New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry #20574 : Add a --filter option to `docker search` #22369

Merged
merged 1 commit into from May 20, 2016

Conversation

Projects
None yet
10 participants
@vdemeester
Member

vdemeester commented Apr 27, 2016

Carrying #20574 : Add a --filter option to docker search 馃悪.

fixes #18980

This make the filtering happening daemon-side, like all other filtering (images, containers, networks, volumes).

Related PR in engine-api is docker/engine-api#214 馃懠

  • Update docs
  • Update api-docs
  • Update integration tests (?)
  • Update completion scripts

馃惛


The following search parameters are allowed:

  • is-official
  • is-automated
  • has-stars

They deprecate

--automated
-s --stars

Signed-off-by: Fabrizio Soppelsa fsoppelsa@mirantis.com

Show outdated Hide outdated api/client/search.go
stars := cmd.Uint([]string{"s", "-stars"}, 0, "Only displays with at least x stars")
cmd.Var(&flFilter, []string{"f", "-filter"}, "Filter output based on conditions provided")
// Deprecated since Docker 1.13 in favor of "--filter"

This comment has been minimized.

@thaJeztah

thaJeztah Apr 29, 2016

Member

s/1.13/1.12/

@thaJeztah

thaJeztah Apr 29, 2016

Member

s/1.13/1.12/

Show outdated Hide outdated api/client/search.go
@@ -62,6 +83,7 @@ func (cli *DockerCli) CmdSearch(args ...string) error {
w := tabwriter.NewWriter(cli.out, 10, 1, 3, ' ', 0)
fmt.Fprintf(w, "NAME\tDESCRIPTION\tSTARS\tOFFICIAL\tAUTOMATED\n")
for _, res := range results {
// --automated and -s, --stars are deprecated since Docker 1.13

This comment has been minimized.

@thaJeztah

thaJeztah Apr 29, 2016

Member

s/1.13/1.12/

@thaJeztah

thaJeztah Apr 29, 2016

Member

s/1.13/1.12/

Show outdated Hide outdated docs/deprecated.md
**Deprecated in Release: [v1.12.0](https://github.com/docker/docker/releases/tag/v1.12.0)**
**Removed In Release: v1.12**

This comment has been minimized.

@thaJeztah

thaJeztah Apr 29, 2016

Member

Target for removal in release: v1.14

@thaJeztah

thaJeztah Apr 29, 2016

Member

Target for removal in release: v1.14

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 1, 2016

Member

@thaJeztah Updated
ping @sdurrheimer @albers for completions (I tried my best but not sure I got it right 馃懠)

Member

vdemeester commented May 1, 2016

@thaJeztah Updated
ping @sdurrheimer @albers for completions (I tried my best but not sure I got it right 馃懠)

Show outdated Hide outdated contrib/completion/bash/docker
case "$prev" in
--stars|-s)
--filter|-f)
COMPREPLY=( $( compgen -S = -W "has-starts is-automated is-official" -- "$cur" ) )

This comment has been minimized.

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

Typo: has-stars

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

Typo: has-stars

This comment has been minimized.

@vdemeester

vdemeester May 1, 2016

Member

oh lol yeah 馃槄

@vdemeester

vdemeester May 1, 2016

Member

oh lol yeah 馃槄

Show outdated Hide outdated contrib/completion/bash/docker
is-official)
COMPREPLY=( $( compgen -W "true false" -- "${cur##*=}" ) )
return
;;

This comment has been minimized.

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

Isn't has-stars also a boolean here ?

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

Isn't has-stars also a boolean here ?

This comment has been minimized.

@vdemeester

vdemeester May 1, 2016

Member

@sdurrheimer no. has-stars takes a number, and filters the list with image that have at least this number of stars 馃槈

@vdemeester

vdemeester May 1, 2016

Member

@sdurrheimer no. has-stars takes a number, and filters the list with image that have at least this number of stars 馃槈

This comment has been minimized.

@thaJeztah

thaJeztah May 1, 2016

Member

Should we change it to just "stars"? Thinking of it, "has-stars" sounds like it's a Boolean indeed

@thaJeztah

thaJeztah May 1, 2016

Member

Should we change it to just "stars"? Thinking of it, "has-stars" sounds like it's a Boolean indeed

This comment has been minimized.

@vdemeester

vdemeester May 1, 2016

Member

@thaJeztah hum, good point !

@vdemeester

vdemeester May 1, 2016

Member

@thaJeztah hum, good point !

This comment has been minimized.

@albers

albers May 1, 2016

Member

+1 for changing it to stars.

@albers

albers May 1, 2016

Member

+1 for changing it to stars.

Show outdated Hide outdated contrib/completion/zsh/_docker
"($help)--no-trunc[Do not truncate output]" \
"($help -s --stars)"{-s=,--stars=}"[Only display with at least X stars]:stars:(0 10 100 1000)" \
"($help -):term: " && ret=0
;;

This comment has been minimized.

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

We need completion values here :)

(search)
    _arguments $(__docker_arguments) \
        $opts_help \
        "($help)*"{-f=,--filter=}"[Filter values]:filter:->filter-options" \
        "($help)--no-trunc[Do not truncate output]" \
        "($help -):term: " && ret=0

    case $state in
        (filter-options)
            __docker_complete_search_filters && ret=0
            ;;
    esac
    ;;
__docker_complete_ps_filters() {
    ...
}

__docker_complete_search_filters() {
    [[ $PREFIX = -* ]] && return 1
    integer ret=1
    declare -a boolean_opts opts

    boolean_opts=('true' 'false')
    opts=('is-automated' 'is-official' 'has-stars')

    if compset -P '*='; then
        case "${${words[-1]%=*}#*=}" in
            (is-automated|is-official)
                _describe -t boolean-filter-opts "filter options" boolean_opts && ret=0
                ;;
            *)
                _message 'value' && ret=0
                ;;
        esac
    else
        _describe -t filter-opts "filter options" opts -qS "=" && ret=0
    fi

    return ret
}

__docker_network_complete_ls_filters() {
    ...
}
@sdurrheimer

sdurrheimer May 1, 2016

Contributor

We need completion values here :)

(search)
    _arguments $(__docker_arguments) \
        $opts_help \
        "($help)*"{-f=,--filter=}"[Filter values]:filter:->filter-options" \
        "($help)--no-trunc[Do not truncate output]" \
        "($help -):term: " && ret=0

    case $state in
        (filter-options)
            __docker_complete_search_filters && ret=0
            ;;
    esac
    ;;
__docker_complete_ps_filters() {
    ...
}

__docker_complete_search_filters() {
    [[ $PREFIX = -* ]] && return 1
    integer ret=1
    declare -a boolean_opts opts

    boolean_opts=('true' 'false')
    opts=('is-automated' 'is-official' 'has-stars')

    if compset -P '*='; then
        case "${${words[-1]%=*}#*=}" in
            (is-automated|is-official)
                _describe -t boolean-filter-opts "filter options" boolean_opts && ret=0
                ;;
            *)
                _message 'value' && ret=0
                ;;
        esac
    else
        _describe -t filter-opts "filter options" opts -qS "=" && ret=0
    fi

    return ret
}

__docker_network_complete_ls_filters() {
    ...
}

This comment has been minimized.

@vdemeester

vdemeester May 1, 2016

Member

@sdurrheimer thank you very much on that !! 馃樆
I wasn't sure I should add them or not, and even more if I could write them 馃槢

By the way, I couldn't find the filter completion on docker images, is that normal ?

@vdemeester

vdemeester May 1, 2016

Member

@sdurrheimer thank you very much on that !! 馃樆
I wasn't sure I should add them or not, and even more if I could write them 馃槢

By the way, I couldn't find the filter completion on docker images, is that normal ?

This comment has been minimized.

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

Looks like a missing bits. I will check that in the next weeks.

@sdurrheimer

sdurrheimer May 1, 2016

Contributor

Looks like a missing bits. I will check that in the next weeks.

This comment has been minimized.

@vdemeester

vdemeester May 1, 2016

Member

@sdurrheimer thanks 馃槈

@vdemeester

This comment has been minimized.

@albers

albers May 1, 2016

Member

Bash completion LGTM (please update the sort order). Nice work, Vincent!

@albers

albers May 1, 2016

Member

Bash completion LGTM (please update the sort order). Nice work, Vincent!

Show outdated Hide outdated contrib/completion/bash/docker
local key=$(__docker_map_key_of_current_option '--filter|-f')
case "$key" in
is-automated)
COMPREPLY=( $( compgen -W "true false" -- "${cur##*=}" ) )

This comment has been minimized.

@albers

albers May 1, 2016

Member

please sort the options alphabetically

@albers

albers May 1, 2016

Member

please sort the options alphabetically

@thaJeztah thaJeztah changed the title from Carry #25074 : Add a --filter option to `docker search` to Carry #20574 : Add a --filter option to `docker search` May 7, 2016

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 7, 2016

Member

ping @vdemeester this needs a rebase now 馃槩

Member

thaJeztah commented May 7, 2016

ping @vdemeester this needs a rebase now 馃槩

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 11, 2016

Member

@thaJeztah updated 馃槈

Member

vdemeester commented May 11, 2016

@thaJeztah updated 馃槈

Show outdated Hide outdated contrib/completion/zsh/_docker
@@ -1123,10 +1147,15 @@ __docker_subcommand() {
(search)
_arguments $(__docker_arguments) \
$opts_help \
"($help)--automated[Only show automated builds]" \
"($help)*"{-f=,--filter=}"[Filter values]:filter: " \

This comment has been minimized.

@sdurrheimer

sdurrheimer May 14, 2016

Contributor

Missing ->filter-options.

"($help)*"{-f=,--filter=}"[Filter values]:filter:->filter-options" \
@sdurrheimer

sdurrheimer May 14, 2016

Contributor

Missing ->filter-options.

"($help)*"{-f=,--filter=}"[Filter values]:filter:->filter-options" \
Show outdated Hide outdated contrib/completion/bash/docker
case "$prev" in
--stars|-s)
--filter|-f)
COMPREPLY=( $( compgen -S = -W "stars is-automated is-official" -- "$cur" ) )

This comment has been minimized.

@albers

albers May 14, 2016

Member

Please sort alphabetically here.

@albers

albers May 14, 2016

Member

Please sort alphabetically here.

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 17, 2016

Member

Thanks @vdemeester, finally got around to testing this. It works good, but some inconsistencies I noticed;

The validation for boolean flags isn't validating all values, and seems to pick the first "valid" one;

# produces an error
docker search --filter is-official=lkjlkj --filter is-official=blabla ubuntu

ERRO[1309] Handler for GET /v1.24/images/search returned error: Invalid filter 'is-official=[lkjlkj blabla]'

# shows only "official"
docker search --filter is-official=false --filter is-official=true ubuntu

# also shows only "official"
docker search --filter is-official=true --filter is-official=false ubuntu

# same (and doesn't complain)
docker search --filter is-official=true --filter is-official=zzz ubuntu

Whereas the "stars" filter validates all values (and picks the "highest" one);

docker search --filter stars=30 --filter stars=bla ubuntu
ERRO[2500] Handler for GET /v1.24/images/search returned error: Invalid filter 'stars=bla'

docker search --filter stars=bla --filter stars=30 ubuntu
ERRO[2500] Handler for GET /v1.24/images/search returned error: Invalid filter 'stars=bla'

docker search --filter stars=30 --filter stars=3 ubuntu
(works - highest number is used)

Not sure what the most logical choice is; should we accept multiple boolean filters? And which one should be picked?

Member

thaJeztah commented May 17, 2016

Thanks @vdemeester, finally got around to testing this. It works good, but some inconsistencies I noticed;

The validation for boolean flags isn't validating all values, and seems to pick the first "valid" one;

# produces an error
docker search --filter is-official=lkjlkj --filter is-official=blabla ubuntu

ERRO[1309] Handler for GET /v1.24/images/search returned error: Invalid filter 'is-official=[lkjlkj blabla]'

# shows only "official"
docker search --filter is-official=false --filter is-official=true ubuntu

# also shows only "official"
docker search --filter is-official=true --filter is-official=false ubuntu

# same (and doesn't complain)
docker search --filter is-official=true --filter is-official=zzz ubuntu

Whereas the "stars" filter validates all values (and picks the "highest" one);

docker search --filter stars=30 --filter stars=bla ubuntu
ERRO[2500] Handler for GET /v1.24/images/search returned error: Invalid filter 'stars=bla'

docker search --filter stars=bla --filter stars=30 ubuntu
ERRO[2500] Handler for GET /v1.24/images/search returned error: Invalid filter 'stars=bla'

docker search --filter stars=30 --filter stars=3 ubuntu
(works - highest number is used)

Not sure what the most logical choice is; should we accept multiple boolean filters? And which one should be picked?

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 18, 2016

Member

Thanks @thaJeztah.
On the filters, it's actually done the same way it's done with the other filters (images & co) and comes from the engine-api code. Currently, the boolean one can hold more than one values and thus, depending on how the code using filters act, it will or will not validate it correctly.

It's the same with dangling=鈥 on images command for example, as long as you have a dangling=true somewhere, it's considered valid 馃槄.

We might want/need to add a function to validate the exact value is this and it's the only value (I'm gonna take a look at it and probably open a PR on that in engine-api).

Member

vdemeester commented May 18, 2016

Thanks @thaJeztah.
On the filters, it's actually done the same way it's done with the other filters (images & co) and comes from the engine-api code. Currently, the boolean one can hold more than one values and thus, depending on how the code using filters act, it will or will not validate it correctly.

It's the same with dangling=鈥 on images command for example, as long as you have a dangling=true somewhere, it's considered valid 馃槄.

We might want/need to add a function to validate the exact value is this and it's the only value (I'm gonna take a look at it and probably open a PR on that in engine-api).

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 18, 2016

Member

Rebased and updated it (on completions thanks @albers @sdurrheimer). Created docker/engine-api#226 for the filtering question.

Member

vdemeester commented May 18, 2016

Rebased and updated it (on completions thanks @albers @sdurrheimer). Created docker/engine-api#226 for the filtering question.

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 18, 2016

Member

We might want/need to add a function to validate the exact value is this and it's the only value (I'm gonna take a look at it and probably open a PR on that in engine-api).

Yes, I think we need some utility methods for those. Basically it got my attention because for the "stars" you were using a loop, so I wondered what happened for other values 馃槃

Member

thaJeztah commented May 18, 2016

We might want/need to add a function to validate the exact value is this and it's the only value (I'm gonna take a look at it and probably open a PR on that in engine-api).

Yes, I think we need some utility methods for those. Basically it got my attention because for the "stars" you were using a loop, so I wondered what happened for other values 馃槃

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 18, 2016

Member

LGTM (code and docs)

improvements to filter validation/parsing will be done in a follow up PR

Member

thaJeztah commented May 18, 2016

LGTM (code and docs)

improvements to filter validation/parsing will be done in a follow up PR

@runcom

This comment has been minimized.

Show comment
Hide comment
@runcom

runcom May 18, 2016

Member

LGTM

Member

runcom commented May 18, 2016

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 18, 2016

Member

ping @SvenDowideit @MHBauer could you review the docs?

Member

thaJeztah commented May 18, 2016

ping @SvenDowideit @MHBauer could you review the docs?

@albers

This comment has been minimized.

Show comment
Hide comment
@albers

albers May 19, 2016

Member

bash completion LGTM. Thanks, Vincent!

Member

albers commented May 19, 2016

bash completion LGTM. Thanks, Vincent!

@sdurrheimer

This comment has been minimized.

Show comment
Hide comment
@sdurrheimer

sdurrheimer May 19, 2016

Contributor

zsh completion LGTM 馃憤

Contributor

sdurrheimer commented May 19, 2016

zsh completion LGTM 馃憤

@SvenDowideit

This comment has been minimized.

Show comment
Hide comment
@SvenDowideit

SvenDowideit May 19, 2016

Contributor

Docs LGTM!

Contributor

SvenDowideit commented May 19, 2016

Docs LGTM!

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 19, 2016

Member

oh! looks like we have a genuine failure on WindowsTP5;

https://jenkins.dockerproject.org/job/Docker-PRs-WoW-TP5/1799/console

23:53:07 ----------------------------------------------------------------------
23:53:07 FAIL: docker_cli_search_test.go:46: DockerSuite.TestSearchCmdOptions
23:53:07 
23:53:07 docker_cli_search_test.go:71:
23:53:07     c.Assert(outSearchCmdOfficialSlice, checker.HasLen, 3) // 1 header, 1 line, 1 carriage return
23:53:07 ... obtained []string = []string{"NAME                                   DESCRIPTION                                     STARS     OFFICIAL   AUTOMATED", "microsoft/dotnet35:windowsservercore   .NET 3.5 Runtime installed in a Windows Se...   1         [OK]       [OK]", "microsoft/iis:windowsservercore        Internet Information Services (IIS) instal...   1         [OK]       [OK]", ""}
23:53:07 ... n int = 3
23:53:07 
23:53:07 
Member

thaJeztah commented May 19, 2016

oh! looks like we have a genuine failure on WindowsTP5;

https://jenkins.dockerproject.org/job/Docker-PRs-WoW-TP5/1799/console

23:53:07 ----------------------------------------------------------------------
23:53:07 FAIL: docker_cli_search_test.go:46: DockerSuite.TestSearchCmdOptions
23:53:07 
23:53:07 docker_cli_search_test.go:71:
23:53:07     c.Assert(outSearchCmdOfficialSlice, checker.HasLen, 3) // 1 header, 1 line, 1 carriage return
23:53:07 ... obtained []string = []string{"NAME                                   DESCRIPTION                                     STARS     OFFICIAL   AUTOMATED", "microsoft/dotnet35:windowsservercore   .NET 3.5 Runtime installed in a Windows Se...   1         [OK]       [OK]", "microsoft/iis:windowsservercore        Internet Information Services (IIS) instal...   1         [OK]       [OK]", ""}
23:53:07 ... n int = 3
23:53:07 
23:53:07 
@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 19, 2016

Member

/ping @jhowardmsft 馃懠
There has probably been some changes on the hub when asked from a windows daemon ?

Member

vdemeester commented May 19, 2016

/ping @jhowardmsft 馃懠
There has probably been some changes on the hub when asked from a windows daemon ?

Show outdated Hide outdated docs/reference/api/docker_remote_api.md
@@ -116,6 +116,7 @@ This section lists each version from latest to oldest. Each listing includes a
* `GET /info` now returns `SecurityOptions` field, showing if `apparmor`, `seccomp`, or `selinux` is supported.
* `GET /networks` now supports filtering by `label` and `driver`.
* `POST /containers/create` now takes `MaximumIOps` and `MaximumIOBps` fields. Windows daemon only.
* `GET /images/search` now takes a `filters` query parameter.

This comment has been minimized.

@MHBauer

MHBauer May 19, 2016

Contributor

maybe link to the deprecated part here as well? As filters is new, and the other stuff is on the way out.

@MHBauer

MHBauer May 19, 2016

Contributor

maybe link to the deprecated part here as well? As filters is new, and the other stuff is on the way out.

This comment has been minimized.

@vdemeester

vdemeester May 20, 2016

Member

API wise it does not deprecate anything really. Before, the filtering for --stars and --automated were done client side.

@vdemeester

vdemeester May 20, 2016

Member

API wise it does not deprecate anything really. Before, the filtering for --stars and --automated were done client side.

Show outdated Hide outdated docs/reference/commandline/search.md
This example displays images with a name containing 'busybox',
at least 3 stars and the description isn't truncated in the output:
$ docker search --filter "is-automated=true stars=3" busybox

This comment has been minimized.

@MHBauer

MHBauer May 19, 2016

Contributor

Is this how it works? you can combine multiple K-V pairs in one arg? Up above it says to use multiple instances of the --filter flag.

@MHBauer

MHBauer May 19, 2016

Contributor

Is this how it works? you can combine multiple K-V pairs in one arg? Up above it says to use multiple instances of the --filter flag.

This comment has been minimized.

@MHBauer

MHBauer May 19, 2016

Contributor

I do not see any of the tests like it. If it is true, I would like to have a test.

@MHBauer

MHBauer May 19, 2016

Contributor

I do not see any of the tests like it. If it is true, I would like to have a test.

This comment has been minimized.

@SvenDowideit

SvenDowideit May 20, 2016

Contributor

oh, good catch! i thought you needed to use multiple --filter args, but this is an interesting approach.

@SvenDowideit

SvenDowideit May 20, 2016

Contributor

oh, good catch! i thought you needed to use multiple --filter args, but this is an interesting approach.

This comment has been minimized.

@thaJeztah

thaJeztah May 20, 2016

Member

good catch indeed. Even though this may work, I don't think we ever documented it like this, perhaps we should change it to multiple --filter args in the example? Or do we want to support this notation?

@thaJeztah

thaJeztah May 20, 2016

Member

good catch indeed. Even though this may work, I don't think we ever documented it like this, perhaps we should change it to multiple --filter args in the example? Or do we want to support this notation?

This comment has been minimized.

@albers

albers May 20, 2016

Member

Do other commands that have a --filter also support this?

@albers

albers May 20, 2016

Member

Do other commands that have a --filter also support this?

This comment has been minimized.

@vdemeester

vdemeester May 20, 2016

Member

oh weird I thought I updated the syntax everywhere.. definitely we should keepuse muktiple --filter notation to be consistent. i'll update.

@vdemeester

vdemeester May 20, 2016

Member

oh weird I thought I updated the syntax everywhere.. definitely we should keepuse muktiple --filter notation to be consistent. i'll update.

This comment has been minimized.

@vdemeester

vdemeester May 20, 2016

Member

@albers nop, no --filter flags supports that, it's a typo in the original PR 馃槤

@vdemeester

vdemeester May 20, 2016

Member

@albers nop, no --filter flags supports that, it's a typo in the original PR 馃槤

@MHBauer

This comment has been minimized.

Show comment
Hide comment
@MHBauer

MHBauer May 19, 2016

Contributor

Left some comments, one needs to be addressed.

Contributor

MHBauer commented May 19, 2016

Left some comments, one needs to be addressed.

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft May 19, 2016

Contributor

@vdemeester I haven't been keeping up to date on the hub stuff - @jstarks is more informed here. But AFAIK, search on Windows just returns a static list regardless of input currently.

Contributor

jhowardmsft commented May 19, 2016

@vdemeester I haven't been keeping up to date on the hub stuff - @jstarks is more informed here. But AFAIK, search on Windows just returns a static list regardless of input currently.

@vdemeester

This comment has been minimized.

Show comment
Hide comment
@vdemeester

vdemeester May 20, 2016

Member

@jhowardmsft thanks ! I'll disable this test for windows for now and will make a followup with unit tests and a windows one 馃懠

Member

vdemeester commented May 20, 2016

@jhowardmsft thanks ! I'll disable this test for windows for now and will make a followup with unit tests and a windows one 馃懠

Add a --filter option to `docker search`
The filtering is made server-side, and the following filters are
supported:

* is-official (boolean)
* is-automated (boolean)
* has-stars (integer)

Signed-off-by: Fabrizio Soppelsa <fsoppelsa@mirantis.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 20, 2016

Member

re-LGTM the docs are fixed now. Moving to "merge" (if it's green)

Member

thaJeztah commented May 20, 2016

re-LGTM the docs are fixed now. Moving to "merge" (if it's green)

@estesp estesp merged commit 642b7b1 into moby:master May 20, 2016

8 checks passed

docker/dco-signed All commits signed
Details
documentation success
Details
experimental Jenkins build Docker-PRs-experimental 18695 has succeeded
Details
gccgo Jenkins build Docker-PRs-gccgo 5552 has succeeded
Details
janky Jenkins build Docker-PRs 27519 has succeeded
Details
userns Jenkins build Docker-PRs-userns 9702 has succeeded
Details
win2lin Jenkins build Docker-PRs-Win2Lin 26063 has succeeded
Details
windowsTP5 Jenkins build Docker-PRs-WoW-TP5 1822 has succeeded
Details
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 20, 2016

Member

Wooooot!

Member

thaJeztah commented May 20, 2016

Wooooot!

@vdemeester vdemeester deleted the vdemeester:carry-pr-25074 branch May 20, 2016

@jimmyxian jimmyxian referenced this pull request Jun 6, 2016

Open

Keep track of the missing API in Swarm #2333

4 of 23 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment