Skip to content

aufs,overlay: disable on eCryptfs #23121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

unclejack
Copy link
Contributor

@unclejack unclejack commented May 31, 2016

- What I did
I've changed the aufs and overlay driver code to disable it when using eCryptfs as a backing file system.

We know aufs and eCryptfs won't work. There's no point in having other people waste time investigating this known problem, opening issues and having to investigate every time.

Fixes #22577
Fixes #19336
Fixes #10380
Fixes #7554

- How I did it
I've added a new FsMagic.

- How to verify it
Set up eCryptfs and switch Docker to use a folder on eCryptfs.

- Description for the changelog
aufs and overlay: disable on eCryptfs

@thaJeztah
Copy link
Member

@thaJeztah
Copy link
Member

Also, if we know why it can't work, perhaps we should leave a short comment with an explanation in the linked issues

@unclejack unclejack force-pushed the disallow_ecryptfs_aufs branch from ea0a034 to ae4d193 Compare June 1, 2016 16:28
@unclejack
Copy link
Contributor Author

@thaJeztah Thanks! It looks like I need to update it to do the same for overlay because it's a problem there as well. I'll make the corresponding changes as well.

@unclejack unclejack force-pushed the disallow_ecryptfs_aufs branch from ae4d193 to e229527 Compare June 1, 2016 18:00
@unclejack unclejack changed the title aufs: disallow aufs on eCryptfs aufs,overlay: disable on eCryptfs Jun 1, 2016
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
@unclejack unclejack force-pushed the disallow_ecryptfs_aufs branch from e229527 to 5e85ec8 Compare June 1, 2016 18:00
@unclejack
Copy link
Contributor Author

@thaJeztah The change is now made to aufs and overlay. The docs have also been updated. I've commented on the newest issue which is open to explain this. The comment also mentions the other issues to make those link to the newest issue without having to comment on every single issue.

PTAL

@thaJeztah
Copy link
Member

Thanks! LGTM

@thaJeztah thaJeztah added this to the 1.12.0 milestone Jun 1, 2016
@cpuguy83
Copy link
Member

cpuguy83 commented Jun 2, 2016

LGTM

@thaJeztah
Copy link
Member

docs LGTM

ping @vdemeester for review/merge 🐶

@vdemeester
Copy link
Member

LGTM 🐯

@vdemeester vdemeester merged commit 22aca92 into moby:master Jun 2, 2016
@unclejack unclejack deleted the disallow_ecryptfs_aufs branch June 2, 2016 11:06
liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
cherry-pick from moby#23121

Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
Signed-off-by: Lei Jitang <leijitang@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants