Add dependency to docker/swarmkit #23361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
the
status/failing-ci
| clone git github.com/docker/go-connections v0.2.0 | ||
| clone git github.com/docker/engine-api 772250a752e34cacaeef7c92b8e0ddf43450b629 | ||
| clone git github.com/docker/go-connections fa2850ff103453a9ad190da0df0af134f0314b3d | ||
| clone git github.com/docker/engine-api 6e7fae3cd9aa40e31cb5833d67a94ee8cff3054c git://github.com/vieux/engine-api.git |
There was a problem hiding this comment.
I assume this won't stay as vieux's repo?
There was a problem hiding this comment.
@ibuildthecloud it should be updated after docker/engine-api#265 is accepted and merged
There was a problem hiding this comment.
@ibuildthecloud definitely, there is a PR in review for that in engine-api 👼
|
This needs a rebase. |
|
If we get the engine-api change merged this one can be merged easily. Its just a bunch of vendored deps |
tonistiigi
force-pushed
the
swarm
branch
2 times, most recently
from
e86213b
to
ed7aeb3
Compare
GordonTheTurtle
added
the
dco/no
|
In the making of this PR:
This branch is now updated with a squashed version of this work to avoid polluting master's history. |
GordonTheTurtle
added
dco/no
GordonTheTurtle
removed
the
dco/no
icecrime
removed
the
status/failing-ci
|
LGTM 👍 |
|
LGTM |
1 similar comment
|
LGTM |
|
Ping @SvenDowideit: can you please help us with that? |
|
Nevermind we figured it out 😇 |
|
|
|
|
Add a dependency to `docker/swarmkit` in preparation for adding first-class Swarm-wide service management inside the Docker Engine as described in our ROADMAP.md. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Jana Radhakrishnan <mrjana@docker.com> Signed-off-by: Victor Vieux <vieux@docker.com> Signed-off-by: Madhu Venugopal <madhu@docker.com>
As described in our ROADMAP.md, introduce new Swarm management API endpoints relying on swarmkit to deploy services. It currently vendors docker/engine-api changes. This PR is fully backward compatible (joining a Swarm is an optional feature of the Engine, and existing commands are not impacted). Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Victor Vieux <vieux@docker.com> Signed-off-by: Daniel Nephin <dnephin@docker.com> Signed-off-by: Jana Radhakrishnan <mrjana@docker.com> Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Victor Vieux <vieux@docker.com>
Signed-off-by: Arnaud Porterie (icecrime) <arnaud.porterie@docker.com>
As described in our ROADMAP.md, introduce new Swarm management commands to call to the corresponding API endpoints. This PR is fully backward compatible (joining a Swarm is an optional feature of the Engine, and existing commands are not impacted). Signed-off-by: Daniel Nephin <dnephin@docker.com> Signed-off-by: Victor Vieux <vieux@docker.com> Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Charles Smith <charles.smith@docker.com>
|
LGTM |
1 similar comment
|
LGTM |
|
experimal timed out after all the tests 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dependency to docker/swarmkit in preparation for adding first-class Swarm-wide service management inside the Docker Engine as described in our ROADMAP.md.