Enable sig-proxy by default in run and attach #2426

vieux · Oct 29, 2013

ping @shykes @crosbymichael @creack

Can we rebase this now that master includes links? :)

tianon · Oct 29, 2013

Can we rebase this now that master includes links? :)

@shykes

Rebased with permission from @shykes; testing now.

tianon · Oct 29, 2013

Rebased with permission from @shykes; testing now.

Shouldn't this proxy with something simple like docker run -i -t tianon/debian bash ? Here's my output:

tianon@host$ docker run -i -t tianon/debian bash
root@cebc0312a73c:/# trap 'echo hello world!' SIGUSR1
root@cebc0312a73c:/# kill -USR1 $$
hello world!
root@cebc0312a73c:/#

Open second terminal, find PID of docker run (in my case, 4093), and do:

tianon@host$ kill -USR1 4093

No extra output on the first terminal. Shouldn't SIGUSR1 be "proxified" to bash?

tianon · Oct 29, 2013

Shouldn't this proxy with something simple like docker run -i -t tianon/debian bash ? Here's my output:

tianon@host$ docker run -i -t tianon/debian bash
root@cebc0312a73c:/# trap 'echo hello world!' SIGUSR1
root@cebc0312a73c:/# kill -USR1 $$
hello world!
root@cebc0312a73c:/#

Open second terminal, find PID of docker run (in my case, 4093), and do:

tianon@host$ kill -USR1 4093

No extra output on the first terminal. Shouldn't SIGUSR1 be "proxified" to bash?

Is this saying that if there is a TTY, we always force-disable sig-proxy ?

+  if config.Tty {
+    sigProxy = false
+  }

tianon · Oct 29, 2013

Is this saying that if there is a TTY, we always force-disable sig-proxy ?

+  if config.Tty {
+    sigProxy = false
+  }

@tianon

@tianon yes, because in tty mode, signals are always proxified, using the raw terminal method

vieux · Oct 29, 2013

@tianon yes, because in tty mode, signals are always proxified, using the raw terminal method

So why didn't my SIGUSR1 get proxified?

tianon · Oct 29, 2013

So why didn't my SIGUSR1 get proxified?

@vieux

@vieux

There is something wrong with this branch. I am getting error messages in the tests.

-- PASS: TestImagesFilter (0.14 seconds)
=== RUN TestServerListOrderedImagesByCreationDate
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: 6f785d278165
[error] api.go:78 HTTP Error: statusCode=404 No such container: 6f785d278165
[error] api.go:1023 Error: No such container: f93fbb878f6b
[error] api.go:78 HTTP Error: statusCode=404 No such container: f93fbb878f6b
[error] api.go:1023 Error: No such container: ec391abab5ea
[error] api.go:78 HTTP Error: statusCode=404 No such container: ec391abab5ea
[error] api.go:1023 Error: No such container: 63aa5fc69086
[error] api.go:78 HTTP Error: statusCode=404 No such container: 63aa5fc69086
[error] api.go:1023 Error: No such container: 588ec30a53cf
[error] api.go:78 HTTP Error: statusCode=404 No such container: 588ec30a53cf
[error] api.go:1023 Error: No such container: d290fb38e240
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e240
[error] api.go:1023 Error: No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:1023 Error: No such container: ff5e69349b4d
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: 6f785d278165
[error] api.go:78 HTTP Error: statusCode=404 No such container: 6f785d278165
[error] api.go:1023 Error: No such container: f93fbb878f6b
[error] api.go:78 HTTP Error: statusCode=404 No such container: f93fbb878f6b
[error] api.go:1023 Error: No such container: ec391abab5ea
[error] api.go:78 HTTP Error: statusCode=404 No such container: ec391abab5ea
[error] api.go:1023 Error: No such container: 63aa5fc69086
[error] api.go:78 HTTP Error: statusCode=404 No such container: 63aa5fc69086
[error] api.go:1023 Error: No such container: ff5e69349b4d
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:1023 Error: No such container: 588ec30a53cf
[error] api.go:78 HTTP Error: statusCode=404 No such container: 588ec30a53cf
[error] api.go:1023 Error: No such container: d290fb38e240
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e240

crosbymichael · Oct 29, 2013

@vieux

There is something wrong with this branch. I am getting error messages in the tests.

-- PASS: TestImagesFilter (0.14 seconds)
=== RUN TestServerListOrderedImagesByCreationDate
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: 6f785d278165
[error] api.go:78 HTTP Error: statusCode=404 No such container: 6f785d278165
[error] api.go:1023 Error: No such container: f93fbb878f6b
[error] api.go:78 HTTP Error: statusCode=404 No such container: f93fbb878f6b
[error] api.go:1023 Error: No such container: ec391abab5ea
[error] api.go:78 HTTP Error: statusCode=404 No such container: ec391abab5ea
[error] api.go:1023 Error: No such container: 63aa5fc69086
[error] api.go:78 HTTP Error: statusCode=404 No such container: 63aa5fc69086
[error] api.go:1023 Error: No such container: 588ec30a53cf
[error] api.go:78 HTTP Error: statusCode=404 No such container: 588ec30a53cf
[error] api.go:1023 Error: No such container: d290fb38e240
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e240
[error] api.go:1023 Error: No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:1023 Error: No such container: ff5e69349b4d
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: 6f785d278165
[error] api.go:78 HTTP Error: statusCode=404 No such container: 6f785d278165
[error] api.go:1023 Error: No such container: f93fbb878f6b
[error] api.go:78 HTTP Error: statusCode=404 No such container: f93fbb878f6b
[error] api.go:1023 Error: No such container: ec391abab5ea
[error] api.go:78 HTTP Error: statusCode=404 No such container: ec391abab5ea
[error] api.go:1023 Error: No such container: 63aa5fc69086
[error] api.go:78 HTTP Error: statusCode=404 No such container: 63aa5fc69086
[error] api.go:1023 Error: No such container: ff5e69349b4d
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:1023 Error: No such container: 588ec30a53cf
[error] api.go:78 HTTP Error: statusCode=404 No such container: 588ec30a53cf
[error] api.go:1023 Error: No such container: d290fb38e240
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e240

@crosbymichael

@crosbymichael can you take another look ?

vieux · Oct 29, 2013

@crosbymichael can you take another look ?

@vieux

Thanks to @vieux, I can verify that this is indeed working for me. :)

tianon · Oct 29, 2013

Thanks to @vieux, I can verify that this is indeed working for me. :)

crosbymichael · Oct 29, 2013

crosbymichael reviewed Oct 29, 2013

View changes

utils/signal_darwin.go

LGTM

crosbymichael · Oct 29, 2013

LGTM

hashar · Nov 28, 2017

This comment has been minimized.

Show comment

Hide comment

hashar Nov 28, 2017

This causes --tty to always disable signal proxying. That is the topic of #9098. It is very annoying and often a source of confusion, eg when you do something like:

$ docker run -it longrunning/thing
<PRESS ^C>

And nothing happens :-] Merci Victor !

This causes --tty to always disable signal proxying. That is the topic of #9098. It is very annoying and often a source of confusion, eg when you do something like:

$ docker run -it longrunning/thing
<PRESS ^C>

And nothing happens :-] Merci Victor !

Enable sig-proxy by default in run and attach

e0b59ab

stop proxy at one point

700a71e

crosbymichael added a commit that referenced this pull request Oct 29, 2013

Merge pull request #2426 from dotcloud/enable_sigproxy_default
Enable sig-proxy by default in run and attach

caa7cf1

crosbymichael merged commit caa7cf1 into master Oct 29, 2013

crosbymichael deleted the enable_sigproxy_default branch Oct 29, 2013

thaJeztah referenced this pull request Dec 24, 2016
Open
docker client doesn't pass signals when a terminal is attached #28872

moby/moby

Enable sig-proxy by default in run and attach #2426

vieux commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

vieux commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

crosbymichael commented Oct 29, 2013

This comment has been minimized.

vieux commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

crosbymichael reviewed Oct 29, 2013

View changes

This comment has been minimized.

crosbymichael commented Oct 29, 2013

crosbymichael added a commit that referenced this pull request Oct 29, 2013

crosbymichael merged commit `caa7cf1` into master Oct 29, 2013

crosbymichael deleted the enable_sigproxy_default branch Oct 29, 2013

thaJeztah referenced this pull request Dec 24, 2016

docker client doesn't pass signals when a terminal is attached #28872

This comment has been minimized.

hashar commented on `e0b59ab` Nov 28, 2017

moby/moby

Join GitHub today

Enable sig-proxy by default in run and attach #2426

Conversation

vieux commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

vieux commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

This comment has been minimized.

crosbymichael commented Oct 29, 2013

This comment has been minimized.

vieux commented Oct 29, 2013

This comment has been minimized.

tianon commented Oct 29, 2013

crosbymichael reviewed Oct 29, 2013 View changes

This comment has been minimized.

crosbymichael commented Oct 29, 2013

crosbymichael added a commit that referenced this pull request Oct 29, 2013

crosbymichael merged commit caa7cf1 into master Oct 29, 2013

crosbymichael deleted the enable_sigproxy_default branch Oct 29, 2013

thaJeztah referenced this pull request Dec 24, 2016

This comment has been minimized.

hashar commented on e0b59ab Nov 28, 2017

crosbymichael reviewed Oct 29, 2013

View changes

crosbymichael merged commit `caa7cf1` into master Oct 29, 2013

hashar commented on `e0b59ab` Nov 28, 2017