New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to version 0.6.5 #2428

Merged
merged 165 commits into from Oct 29, 2013

Conversation

Projects
None yet
@crosbymichael
Contributor

crosbymichael commented Oct 29, 2013

No description provided.

rogpeppe and others added some commits Sep 23, 2013

Fixes issues with mounting subdirectories of /mnt in container.
Tested with
mkdir /mnt/data
docker run -v /mnt/data:/mnt/data  -t ubuntu:12.10 touch /mnt/data/bar

Expected /mnt/data/bar on host.
Refactor mkimage-debootstrap.sh to be much more full-featured
This includes the following:
- options to control certain parameters
- an option specifically for creating tarballs directly, esp. for dockerbrew
- the addition of the updates and security repositories for Debian images
- the addition of the universe, updates, and security repositories for Ubuntu images
- more correct tagging of Debian images
- tagging of Ubuntu image versions (12.04, 12.10, etc) and latest tag for LTS
make copy paste user friendly
copying only the first line killed my sources.list file
c&p improvement for 13.04
first line killed sources list
Jérôme Petazzoni
Merge pull request #2253 from jpetazzo/infrastructure-docs
Try a different presentation of infrastructure documentation.
Merge pull request #2283 from tmc/master
Make mkimage-arch.sh a little more clear
Remove spurious messages, and use proper args expansion.
Also, display some (hopefully helpful) message when no command was given.
Change bundle order, and fix shell array expansion.
I believe that it is helpful to build the binary first. That way,
if you interrupt the tests, you still get a binary to play with.
If you run the tests first and interrupt them, no binary for you!

Also, the second part of this commit is an undeniable proof that
Bash array syntax is nothing else than an elaborate troll by Bash
authors.
Solomon Hykes
hack: encode the name of the current test in temporary directories, f…
…or easier tracking

Conflicts:
	utils_test.go
Merge pull request #2282 from shykes/fix-tests
Tests: Cleanup the test suite
Andy Rothfusz
Merge pull request #2281 from metalivedev/cleanupformat
Clean up build warnings. Remove redundant files.
Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated CHANGELOG.md
Show outdated Hide outdated CHANGELOG.md
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Oct 29, 2013

Collaborator

LGTM

Collaborator

vieux commented Oct 29, 2013

LGTM

crosbymichael added a commit that referenced this pull request Oct 29, 2013

@crosbymichael crosbymichael merged commit 4f6ce1b into release Oct 29, 2013

@crosbymichael crosbymichael deleted the bump_0.6.5 branch Oct 29, 2013

@tobstarr

This comment has been minimized.

Show comment
Hide comment
@tobstarr

tobstarr Nov 14, 2013

Contributor

Is that really necessary in the base package? This breaks cross compilation of the docker root package when being used as a library.

Contributor

tobstarr commented on runtime.go in 7c08aee Nov 14, 2013

Is that really necessary in the base package? This breaks cross compilation of the docker root package when being used as a library.

This comment has been minimized.

Show comment
Hide comment
@fsouza

fsouza Nov 14, 2013

Contributor

Yes, it is. This import registers the sqlite3 driver, see line 606.

Contributor

fsouza replied Nov 14, 2013

Yes, it is. This import registers the sqlite3 driver, see line 606.

@tt

This comment has been minimized.

Show comment
Hide comment
@tt

tt Mar 4, 2014

Why is this ever useful? The value is embedded in the key.

tt commented on links.go in 1de23f1 Mar 4, 2014

Why is this ever useful? The value is embedded in the key.

This comment has been minimized.

Show comment
Hide comment
@jamtur01

jamtur01 Mar 4, 2014

Contributor

It's a useful set of shortcuts IMHO.

Contributor

jamtur01 replied Mar 4, 2014

It's a useful set of shortcuts IMHO.

This comment has been minimized.

Show comment
Hide comment
@tt

tt Mar 4, 2014

I get the port could be mapped to a different port and therefore useful, but the protocol will always be the same, so EXAMPLE_PORT_80_TCP_PROTO will always be tcp. When would you use that?

tt replied Mar 4, 2014

I get the port could be mapped to a different port and therefore useful, but the protocol will always be the same, so EXAMPLE_PORT_80_TCP_PROTO will always be tcp. When would you use that?

This comment has been minimized.

Show comment
Hide comment
@tianon

tianon Mar 4, 2014

Member

The idea is that these can now be changed in the future. ie, the *_PORT variable seems pointless today since it's always the same as what's specified in the name, but in the future, Docker could be doing some even cross-host mapping to make this work properly, and would likely be munging the ports in the process.

Member

tianon replied Mar 4, 2014

The idea is that these can now be changed in the future. ie, the *_PORT variable seems pointless today since it's always the same as what's specified in the name, but in the future, Docker could be doing some even cross-host mapping to make this work properly, and would likely be munging the ports in the process.

This comment has been minimized.

Show comment
Hide comment
@tt

tt Mar 4, 2014

I agree that keeping the port is useful, but you still can't change the protocol. I'm only arguing about that specific line.

tt replied Mar 4, 2014

I agree that keeping the port is useful, but you still can't change the protocol. I'm only arguing about that specific line.

@arthurlogilab

This comment has been minimized.

Show comment
Hide comment
@arthurlogilab

arthurlogilab Jul 13, 2016

Am interested in this functionality, can be of any help to get this patch integrated ?

arthurlogilab commented on bc8a108 Jul 13, 2016

Am interested in this functionality, can be of any help to get this patch integrated ?

@hashar

This comment has been minimized.

Show comment
Hide comment
@hashar

hashar Nov 28, 2017

This causes --tty to always disable signal proxying. That is the topic of #9098. It is very annoying and often a source of confusion, eg when you do something like:

$ docker run -it longrunning/thing
<PRESS ^C>

And nothing happens :-] Merci Victor !

hashar commented on e0b59ab Nov 28, 2017

This causes --tty to always disable signal proxying. That is the topic of #9098. It is very annoying and often a source of confusion, eg when you do something like:

$ docker run -it longrunning/thing
<PRESS ^C>

And nothing happens :-] Merci Victor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment