Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBump to version 0.6.5 #2428
Conversation
rogpeppe
and others
added some commits
Sep 23, 2013
shykes
reviewed
Oct 29, 2013
shykes
reviewed
Oct 29, 2013
shykes
reviewed
Oct 29, 2013
shykes
reviewed
Oct 29, 2013
shykes
reviewed
Oct 29, 2013
jamtur01
reviewed
Oct 29, 2013
tlunter
and others
added some commits
Oct 29, 2013
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM |
added a commit
that referenced
this pull request
Oct 29, 2013
crosbymichael
merged commit 4f6ce1b
into
release
Oct 29, 2013
crosbymichael
deleted the
bump_0.6.5
branch
Oct 29, 2013
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tobstarr
Nov 14, 2013
Contributor
Is that really necessary in the base package? This breaks cross compilation of the docker root package when being used as a library.
|
Is that really necessary in the base package? This breaks cross compilation of the docker root package when being used as a library. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yes, it is. This import registers the sqlite3 driver, see line 606. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tt
commented on links.go in 1de23f1
Mar 4, 2014
|
Why is this ever useful? The value is embedded in the key. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
It's a useful set of shortcuts IMHO. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tt
Mar 4, 2014
I get the port could be mapped to a different port and therefore useful, but the protocol will always be the same, so EXAMPLE_PORT_80_TCP_PROTO will always be tcp. When would you use that?
tt
replied
Mar 4, 2014
|
I get the port could be mapped to a different port and therefore useful, but the protocol will always be the same, so |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tianon
Mar 4, 2014
Member
The idea is that these can now be changed in the future. ie, the *_PORT variable seems pointless today since it's always the same as what's specified in the name, but in the future, Docker could be doing some even cross-host mapping to make this work properly, and would likely be munging the ports in the process.
|
The idea is that these can now be changed in the future. ie, the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
tt
Mar 4, 2014
I agree that keeping the port is useful, but you still can't change the protocol. I'm only arguing about that specific line.
tt
replied
Mar 4, 2014
|
I agree that keeping the port is useful, but you still can't change the protocol. I'm only arguing about that specific line. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arthurlogilab
Jul 13, 2016
Am interested in this functionality, can be of any help to get this patch integrated ?
arthurlogilab
commented on bc8a108
Jul 13, 2016
|
Am interested in this functionality, can be of any help to get this patch integrated ? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hashar
Nov 28, 2017
This causes --tty to always disable signal proxying. That is the topic of #9098. It is very annoying and often a source of confusion, eg when you do something like:
$ docker run -it longrunning/thing
<PRESS ^C>
And nothing happens :-] Merci Victor !
hashar
commented on e0b59ab
Nov 28, 2017
|
This causes
And nothing happens :-] Merci Victor ! |
crosbymichael commentedOct 29, 2013
No description provided.