New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container commit doesn't use a query parameter, uses POST body #2443

Merged
merged 2 commits into from Oct 29, 2013

Conversation

Projects
None yet
3 participants
@tlunter
Contributor

tlunter commented Oct 29, 2013

Figured I'd update the latest remote API docs for this. Since the code for this area doesn't have anything regarding supporting older versions, not sure how this should show up in the docs. But on the other hand, as I'm looking through the Docker history, I don't see this ever taking a run query parameter over the POST body style.

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Oct 29, 2013

Collaborator

@tlunter you are right, we never used the run parameter, could you please update all versions ?

Collaborator

vieux commented Oct 29, 2013

@tlunter you are right, we never used the run parameter, could you please update all versions ?

@tlunter

This comment has been minimized.

Show comment
Hide comment
@tlunter

tlunter Oct 29, 2013

Contributor

@vieux I think I got them all

Contributor

tlunter commented Oct 29, 2013

@vieux I think I got them all

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Oct 29, 2013

Collaborator

@metalivedev can you take a look please ?

Collaborator

vieux commented Oct 29, 2013

@metalivedev can you take a look please ?

@metalivedev

This comment has been minimized.

Show comment
Hide comment
@metalivedev

metalivedev Oct 29, 2013

Contributor

Thanks for taking the extra time to fix them all!

Contributor

metalivedev commented Oct 29, 2013

Thanks for taking the extra time to fix them all!

metalivedev pushed a commit that referenced this pull request Oct 29, 2013

Andy Rothfusz
Merge pull request #2443 from tlunter/fix_remote_api_doc
Container commit doesn't use a query parameter, uses POST body

@metalivedev metalivedev merged commit baf23d3 into moby:master Oct 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment