Some format and syntax changes.

[jamtur01]

• Added sudo as per convention to docker commands
• Break the Dockerfile block up
• Redis is a proper noun
• Minor whitespace fixes

[dudebout]

Sudo is not desirable. Users should add themselves to the docker group to not have to use sudo.

[dudebout]

Sudo is not desirable. Users should add themselves to the docker group to not have to use sudo.

[jamtur01]

I disagree :) Also the sudo syntax is used in 90% of the documentation currently. Unless every document includes a header saying "This assumes you've added yourself to the docker group" then none of the commands will work. That violates the principal of least surprise to me.

[jamtur01]

I disagree :) Also the sudo syntax is used in 90% of the documentation currently. Unless every document includes a header saying "This assumes you've added yourself to the docker group" then none of the commands will work. That violates the principal of least surprise to me.

[dudebout]

To me this should be part of the installation process as it is right now. Then sudo should be dropped from all the other documentation places. This is noise that does not add anything.

To me, a command prefixed by sudo tells me that I cannot run it on a machine on which I do not have sudo access. I can run docker on a machine on which I do not have sudo access by having an administrator add me to the docker group.

[dudebout]

To me this should be part of the installation process as it is right now. Then sudo should be dropped from all the other documentation places. This is noise that does not add anything.

To me, a command prefixed by sudo tells me that I cannot run it on a machine on which I do not have sudo access. I can run docker on a machine on which I do not have sudo access by having an administrator add me to the docker group.

[dudebout]

I do agree on being consistent and I also agree on giving the documentation a little lovin as you are doing.

[dudebout]

I do agree on being consistent and I also agree on giving the documentation a little lovin as you are doing.

[jamtur01]

Currently its not consistent either way - my view is that we make it consistent towards sudo, update the installation documentation and then make it all consistent towards no sudo with some notes/warnings/etc scattered where needed. YMMV and thanks for the feedback! :)

[jamtur01]

Currently its not consistent either way - my view is that we make it consistent towards sudo, update the installation documentation and then make it all consistent towards no sudo with some notes/warnings/etc scattered where needed. YMMV and thanks for the feedback! :)

[jpetazzo]

/cc @metalivedev

[jpetazzo]

/cc @metalivedev

[metalivedev]

using sudo is the current documentation standard. It is a reminder that docker does require special privileges to run.

[metalivedev]

using sudo is the current documentation standard. It is a reminder that docker does require special privileges to run.

[dudebout]

@metalivedev only the daemon does. Then I do not need it I just need to be in a group which is way way weaker than having super user access.

[dudebout]

@metalivedev only the daemon does. Then I do not need it I just need to be in a group which is way way weaker than having super user access.

[metalivedev]

#2552 might also interest you, @jamtur01 if you're looking for a next project :-)

@dudebout the "docker" group may be equivalent to having root access on the host. Please see #1655

[metalivedev]

#2552 might also interest you, @jamtur01 if you're looking for a next project :-)

@dudebout the "docker" group may be equivalent to having root access on the host. Please see #1655

[jamtur01]

@metalivedev I'll tackle that after #2534 gets merged - clean start on top of that.

[jamtur01]

@metalivedev I'll tackle that after #2534 gets merged - clean start on top of that.

[dudebout]

@metalivedev Thanks for the pointer to #1655. In this case it is more reasonnable to keep sudo.

[dudebout]

@metalivedev Thanks for the pointer to #1655. In this case it is more reasonnable to keep sudo.