Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump notary version to 0.4.2 #27074

Merged
merged 2 commits into from Oct 17, 2016

Conversation

@cyli
Copy link
Contributor

commented Sep 30, 2016

This bumps the notary dependency up to 0.4.2 (full changelogs here).

The docker-client-relevant behavior changes are:

  • Will now compile under windows #970
  • Improved error messages for client authentication errors #972
  • Support for finding keys that are anywhere in the ~/.docker/trust/private directory, not just under ~/.docker/trust/private/root_keys or ``~/.docker/trust/private/tuf_keys` #981
  • Previously, on any error updating, the client would fall back on the cache. Now we only do so if there is a network error or if the server is unavailable or missing the TUF data. Invalid TUF data will cause the update to fail - for example if there was an invalid root rotation. #982
  • Improve root validation and yubikey debug logging #858 #891
  • Warn if certificates for root or delegations are near expiry #802
  • Warn if role metadata is near expiry #786
  • Fix passphrase retrieval attempt counting and terminal detection #906

cc @riyazdf @endophage

@cyli cyli force-pushed the cyli:bump-notary-version branch from 480c0f6 to 08f65ef Oct 1, 2016

@cyli cyli changed the title Bump notary version to 0.4.1 Bump notary version to 0.4.2 Oct 1, 2016

@cyli cyli force-pushed the cyli:bump-notary-version branch from 08f65ef to 5b37a11 Oct 5, 2016

@vieux

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2016

@vieux

This comment has been minimized.

Copy link
Collaborator

commented Oct 5, 2016

SGTM

@endophage

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2016

LGTM!

@cyli cyli force-pushed the cyli:bump-notary-version branch from 5b37a11 to 8f46f28 Oct 5, 2016

@cyli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2016

^sorry, fixed an error message typo in two of the tests

@cyli cyli force-pushed the cyli:bump-notary-version branch 6 times, most recently from bd8bd2f to f42caa5 Oct 5, 2016

@justincormack

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2016

LGTM

1 similar comment
@riyazdf

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2016

LGTM

@cyli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2016

bump. :) can this be merged?

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

Looks like some related commits could be squashed, or are we good with having them all separate?

@cyli

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2016

@thaJeztah I have no strong feelings. I can squash them if you like.

cyli added 2 commits Sep 21, 2016
Bump vendored and dockerfile notary version to v0.4.2
Signed-off-by: cyli <cyli@twistedmatrix.com>
Fix API incompatibilities between notary v0.3.0 and v0.4.2:
- some function signatures have changed - use the new ones
- re-generate the notary delegation key certs, since notary doesn't allow SHA1
- fix some error message mapping because now if a root rotation fails to validate trusted operations will fail

Signed-off-by: cyli <cyli@twistedmatrix.com>

@cyli cyli force-pushed the cyli:bump-notary-version branch from f42caa5 to 0797af3 Oct 15, 2016

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

@cyli perhaps split in "bump" commits and "fix" commits

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

oh! done already, haha

@thaJeztah
Copy link
Member

left a comment

LGTM

@vdemeester vdemeester merged commit a7c883f into moby:master Oct 17, 2016

5 checks passed

docker/dco-signed All commits signed
Details
experimental Jenkins build Docker-PRs-experimental 24943 has succeeded
Details
janky Jenkins build Docker-PRs 33540 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 2097 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 4391 has succeeded
Details

@thaJeztah thaJeztah added this to the 1.13.0 milestone Oct 17, 2016

dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.