New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where volume metadata was not removed #29083

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
5 participants
@cpuguy83
Contributor

cpuguy83 commented Dec 2, 2016

Basically, we create some on-disk metadata about the volume to store
things like volume labels.
This was never being cleaned up when the volume is removed.

ping @vieux

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Dec 3, 2016

Contributor

Never seen this, but certainly not related:

22:11:53 FAIL: docker_api_build_test.go:14: DockerSuite.TestBuildApiDockerFileRemote
22:11:53 
22:11:53 docker_api_build_test.go:36:
22:11:53     c.Assert(out, checker.Contains, "/tmp/Dockerfile")
22:11:53 ... obtained string = "" +
22:11:53 ...     "{\"stream\":\"Step 1 : FROM busybox\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\" ---\\u003e d9551b4026f0\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"Step 2 : COPY * /tmp/\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\" ---\\u003e 5ea8782d8971\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"Removing intermediate container c794f549c34e\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"Step 3 : RUN find / -name ba*\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\" ---\\u003e Running in fdae02bc7b9f\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"/proc/acpi/battery\\n/proc/sys/net/ipv4/neigh/eth0/base_reachable_time\\n/proc/sys/net/ipv4/neigh/eth0/base_reachable_time_ms\\n/proc/sys/net/ipv4/neigh/lo/base_reachable_time\\n/proc/sys/net/ipv4/neigh/lo/base_reachable_time_ms\\n/proc/sys/net/ipv4/vs/backup_only\\n/proc/sys/net/ipv6/neigh/eth0/base_reachable_time\\n/proc/sys/net/ipv6/neigh/eth0/base_reachable_time_ms\\n/proc/sys/net/ipv6/neigh/lo/base_reachable_time\\n/proc/sys/net/ipv6/neigh/lo/base_reachable_time_ms\\n/bin/basename\\n/bin/base64\\n/sys/fs/ext4/features/batched_discard\\n/sys/bus/acpi/drivers/battery\\n/sys/devices/system/machinecheck/machinecheck0/bank0\\n/sys/devices/system/machinecheck/machinecheck0/bank1\\n/sys/devices/system/machinecheck/machinecheck1/bank0\\n/sys/devices/system/machinecheck/machinecheck1/bank1\\n/sys/class/backlight\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"\\u001b[91mfind: /sys/firmware/acpi: Permission denied\\nfind: /sys/firmware/memmap: Permission denied\\n\\u001b[0m\"}\r\n" +
22:11:53 ...     "{\"stream\":\"/sys/module/pstore/parameters/backend\\n/sys/module/battery\\n\"}\r\n" +
22:11:53 ...     "{\"errorDetail\":{\"code\":1,\"message\":\"The command '/bin/sh -c find / -name ba*' returned a non-zero code: 1\"},\"error\":\"The command '/bin/sh -c find / -name ba*' returned a non-zero code: 1\"}\r\n"
22:11:53 ... substring string = "/tmp/Dockerfile"
22:11:53 
22:11:53 
22:11:53 ----------------------------------------------------------------------
Contributor

cpuguy83 commented Dec 3, 2016

Never seen this, but certainly not related:

22:11:53 FAIL: docker_api_build_test.go:14: DockerSuite.TestBuildApiDockerFileRemote
22:11:53 
22:11:53 docker_api_build_test.go:36:
22:11:53     c.Assert(out, checker.Contains, "/tmp/Dockerfile")
22:11:53 ... obtained string = "" +
22:11:53 ...     "{\"stream\":\"Step 1 : FROM busybox\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\" ---\\u003e d9551b4026f0\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"Step 2 : COPY * /tmp/\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\" ---\\u003e 5ea8782d8971\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"Removing intermediate container c794f549c34e\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"Step 3 : RUN find / -name ba*\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\" ---\\u003e Running in fdae02bc7b9f\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"/proc/acpi/battery\\n/proc/sys/net/ipv4/neigh/eth0/base_reachable_time\\n/proc/sys/net/ipv4/neigh/eth0/base_reachable_time_ms\\n/proc/sys/net/ipv4/neigh/lo/base_reachable_time\\n/proc/sys/net/ipv4/neigh/lo/base_reachable_time_ms\\n/proc/sys/net/ipv4/vs/backup_only\\n/proc/sys/net/ipv6/neigh/eth0/base_reachable_time\\n/proc/sys/net/ipv6/neigh/eth0/base_reachable_time_ms\\n/proc/sys/net/ipv6/neigh/lo/base_reachable_time\\n/proc/sys/net/ipv6/neigh/lo/base_reachable_time_ms\\n/bin/basename\\n/bin/base64\\n/sys/fs/ext4/features/batched_discard\\n/sys/bus/acpi/drivers/battery\\n/sys/devices/system/machinecheck/machinecheck0/bank0\\n/sys/devices/system/machinecheck/machinecheck0/bank1\\n/sys/devices/system/machinecheck/machinecheck1/bank0\\n/sys/devices/system/machinecheck/machinecheck1/bank1\\n/sys/class/backlight\\n\"}\r\n" +
22:11:53 ...     "{\"stream\":\"\\u001b[91mfind: /sys/firmware/acpi: Permission denied\\nfind: /sys/firmware/memmap: Permission denied\\n\\u001b[0m\"}\r\n" +
22:11:53 ...     "{\"stream\":\"/sys/module/pstore/parameters/backend\\n/sys/module/battery\\n\"}\r\n" +
22:11:53 ...     "{\"errorDetail\":{\"code\":1,\"message\":\"The command '/bin/sh -c find / -name ba*' returned a non-zero code: 1\"},\"error\":\"The command '/bin/sh -c find / -name ba*' returned a non-zero code: 1\"}\r\n"
22:11:53 ... substring string = "/tmp/Dockerfile"
22:11:53 
22:11:53 
22:11:53 ----------------------------------------------------------------------
Fix issue where volume metadata was not removed
Basically, we create some on-disk metadata about the volume to store
things like volume labels.
This was never being cleaned up when the volume is removed.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Dec 5, 2016

Collaborator

LGTM ping @tonistiigi

Collaborator

vieux commented Dec 5, 2016

LGTM ping @tonistiigi

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Dec 5, 2016

Collaborator

ping @LK4D4

Collaborator

vieux commented Dec 5, 2016

ping @LK4D4

@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Dec 5, 2016

Member

LGTM

Member

tonistiigi commented Dec 5, 2016

LGTM

@vieux vieux merged commit 7613b23 into moby:1.12.x Dec 5, 2016

3 of 4 checks passed

windowsRS1 Jenkins build Docker-PRs-WoW-RS1 7373 has failed
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 27848 has succeeded
Details
janky Jenkins build Docker-PRs 36420 has succeeded
Details

@vieux vieux added this to the 1.12.4 milestone Dec 7, 2016

@vieux vieux changed the title from [1.12.x] Fix issue where volume metadata was not removed to Fix issue where volume metadata was not removed Dec 7, 2016

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 9, 2017

Member

@cpuguy83 I was looking if this one had to be still backported to master, but I think this was covered by 6ef1060#diff-c10acbeaf112bd0cfb7e9bb030618773R151 (#29042), correct?

Member

thaJeztah commented Jun 9, 2017

@cpuguy83 I was looking if this one had to be still backported to master, but I think this was covered by 6ef1060#diff-c10acbeaf112bd0cfb7e9bb030618773R151 (#29042), correct?

thaJeztah added a commit to thaJeztah/docker that referenced this pull request Jun 9, 2017

Merge pull request moby#29083 from cpuguy83/fix_volume_rm_metadata
[1.12.x] Fix issue where volume metadata was not removed
(cherry picked from commit 7613b23)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Conflicts:
	volume/store/store.go
	volume/store/store_test.go

@thaJeztah thaJeztah referenced this pull request Jun 9, 2017

Merged

"back port" #29083 #33608

@cpuguy83 cpuguy83 deleted the cpuguy83:fix_volume_rm_metadata branch Jun 11, 2017

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Jun 11, 2017

Contributor

@thaJeztah Yep, all good here.

Contributor

cpuguy83 commented Jun 11, 2017

@thaJeztah Yep, all good here.

thaJeztah added a commit that referenced this pull request Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment