GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe the log config setting should be ignored by the builder. The logs should also be handled by the daemon.
IMO we should set impact/changelog label for this PR.
WDYT? @dnephin @thaJeztah
Yes, setting changelog SGTM
Per the discussion on #19259 (comment), we could also consider using logs=none, or would that be too much of a change?
Alternatively, set logs=none by default, and use logs=json-file if --rm=false is set
I believe if you use logs=none then you don't see the output during the build.
@dnephin I always using none and I see the output, it depends on attach and not logs.
This is definitely a bug IMO, so I'm putting it in code-review.
@dnephin needs a rebase 👼
Still insisting on trying "none" :)
Ignore the daemon log config when building images.
Logs created by build containers should be handled by the daemon, not by logging drivers.
Signed-off-by: Daniel Nephin <email@example.com>
Looks like none works! I've made that change