Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use binary frame for websocket attach endpoint #30460
- What I did
- How I did it
This fix address the issue by change
- How to verify it
This fix is tested manually with Safari. The docker daemon is inside a Linux Virtual Machine.
Create a container with:
Use the following url (172.16.66.128:2375 is the tcp address of the daemon):
and the following websocket.html:
The following error is returned without fix:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
This fix fixes #28176.
Signed-off-by: Yong Tang firstname.lastname@example.org
referenced this pull request
Jan 26, 2017
@yongtang can you add a note to the API change history? https://github.com/docker/docker/blob/master/docs/api/version-history.md
IIUC, users of this API endpoint may have to make changes for this, so it's important to mention this change
@thaJeztah the PR has been updated with API change history docs. Please take a look.