Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add bash completion for `docker plugin upgrade` #30823
Notes for reviewers:
This only works on the master.
1.13.1 tag and
1.13.x, bash correctly completes
upgrade but afterwards it doesn't complete the available plugins.
@albers if we were to do a
1.13.2 do you know what other commit would need to be cherry-picked into
1.13.x for this to work?
@mlaventure That's really strange. Maybe I'm doing sonething wrong. Here's what I did:
$ git branch * master $ git fetch origin 1.13.x From https://github.com/docker/docker * branch 1.13.x -> FETCH_HEAD $ git checkout 1.13.x Branch 1.13.x set up to track remote branch 1.13.x from origin. Switched to a new branch '1.13.x' $ git fetch albers completion-plugin-upgrade From https://github.com/albers/docker * branch completion-plugin-upgrade -> FETCH_HEAD $ git cherry-pick 2c52ec8403d721e567a7c3c129fc38c650b85ba4 [1.13.x 32428de] Add bash completion for `docker plugin upgrade` Date: Wed Feb 8 13:40:13 2017 +0100 1 file changed, 20 insertions(+) $ git log --oneline -2 32428de Add bash completion for `docker plugin upgrade` e5a90d4 Merge pull request #30875 from albers/fix-30858 $ make binary shell BIND_DIR=.
In a separate shell
$ docker exec -ti $(docker ps -lq) dockerd
Back in DIND
root@1af0ae499ea0:~# docker plugin install --grant-all-permissions vieux/sshfs latest: Pulling from vieux/sshfs 86b5589884b3: Download complete Digest: sha256:e5e584b1a2d0855d0be5817506e07f774c7c248db42015caa1e605a60c256007 Status: Downloaded newer image for vieux/sshfs:latest Installed plugin vieux/sshfs root@1af0ae499ea0:~# docker plugin upgrade <tab> # works!