New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpu spin waiting for log write events #31070

Merged
merged 1 commit into from Feb 17, 2017

Conversation

Projects
None yet
6 participants
@cpuguy83
Contributor

cpuguy83 commented Feb 16, 2017

This loop is not ever going to return since it's never actually setting
the err var except on the first iteration.

Fixes #31060

@cpuguy83 cpuguy83 added this to the 1.13.2 milestone Feb 16, 2017

@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Feb 16, 2017

Member

LGTM

Member

tonistiigi commented Feb 16, 2017

LGTM

Fix cpu spin waiting for log write events
This loop is not ever going to return since it's never actually setting
the `err` var except on the first iteration.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Feb 16, 2017

Contributor

This is ready.

Contributor

cpuguy83 commented Feb 16, 2017

This is ready.

@dnephin

LGTM

@cpuguy83 cpuguy83 merged commit 39851ea into moby:master Feb 17, 2017

4 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 30807 has succeeded
Details
janky Jenkins build Docker-PRs 39422 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 10481 has succeeded
Details

@cpuguy83 cpuguy83 deleted the cpuguy83:31060_fix_log_read_spin branch Feb 17, 2017

@thaJeztah thaJeztah added this to pick in 17.03.2-maybe Feb 18, 2017

thaJeztah added a commit to thaJeztah/docker that referenced this pull request Feb 18, 2017

Merge pull request moby#31070 from cpuguy83/31060_fix_log_read_spin
Fix cpu spin waiting for log write events
(cherry picked from commit 39851ea)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@thaJeztah thaJeztah referenced this pull request Feb 18, 2017

Merged

17.03 cherry picks #31140

@thaJeztah thaJeztah moved this from pick to picked in 17.03.2-maybe Feb 18, 2017

@thaJeztah thaJeztah removed this from picked in 17.03.2-maybe Feb 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment