New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the network attachment on allocation failure #31073

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
6 participants
@aboch
Contributor

aboch commented Feb 16, 2017

  • otherwise the attachment task will stay in store and
    consume IP addressess and there is no way to remove it.

Fixes #31066

- A picture of a cute animal (not mandatory but encouraged)

vez

@aboch aboch added this to the 1.13.2 milestone Feb 16, 2017

@mavenugo

Thanks @aboch @vikstrous

LGTM

Release the network attachment on allocation failure
- otherwise the attachment task will stay in store and
  consume IP addresses and there is no way to remove it.

Signed-off-by: Alessandro Boch <aboch@docker.com>
@vdemeester

LGTM 🐸

@aboch

This comment has been minimized.

Show comment
Hide comment
@aboch

aboch Feb 16, 2017

Contributor

Please hold on on merging
All good.

Contributor

aboch commented Feb 16, 2017

Please hold on on merging
All good.

@vdemeester vdemeester merged commit 55e2ed2 into moby:master Feb 16, 2017

4 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 30829 has succeeded
Details
janky Jenkins build Docker-PRs 39444 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 10506 has succeeded
Details
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Feb 18, 2017

Member

cherry-picked through #31138

Member

thaJeztah commented Feb 18, 2017

cherry-picked through #31138

@aboch aboch deleted the aboch:naip branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment