New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow sub second in healthcheck options in Dockerfile #31177

Merged
merged 1 commit into from Mar 8, 2017

Conversation

Projects
None yet
4 participants
@allencloud
Contributor

allencloud commented Feb 20, 2017

Signed-off-by: allencloud allen.sun@daocloud.io

This is a follow-up for #30203

Since in docker/master, we do not allow docker daemon to validate healthcheck parameter Timeout and Interval to be not less than 1 second. We discussed about that we should not support sub second validation.

Without this PR, if a user specifies Timeout in Dockerfile to be 0.5s(sub second), then the docker build will be OK, and let us call the built image to be built-image. However, the docker run built-image will report error, since PR #30203.

- What I did

  1. validate healthcheck parameters Timeout and Interval in Dockerfile options.

ping @cpuguy83 @LK4D4

do not allow sub second in healthcheck options in Dockerfile
Signed-off-by: allencloud <allen.sun@daocloud.io>
@coolljt0725

This comment has been minimized.

Show comment
Hide comment
@coolljt0725

coolljt0725 Mar 7, 2017

Contributor

LGTM ping @cpuguy83 @LK4D4

Contributor

coolljt0725 commented Mar 7, 2017

LGTM ping @cpuguy83 @LK4D4

@thaJeztah

LGTM

@thaJeztah thaJeztah merged commit fb1890f into moby:master Mar 8, 2017

4 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 30953 has succeeded
Details
janky Jenkins build Docker-PRs 39567 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 10630 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 8, 2017

@allencloud allencloud deleted the allencloud:donot-allow-subsecond-in-dockerfile-healthcheck branch Mar 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment