New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing the default network for a stack #31258

Merged
merged 1 commit into from Mar 7, 2017

Conversation

@dnephin
Member

dnephin commented Feb 22, 2017

Fixes #31228

Support customizing the default network for a stack.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin
Member

dnephin commented Mar 3, 2017

@vdemeester

vdemeester approved these changes Mar 3, 2017 edited

LGTM 🐸

@cpuguy83

LGTM

@cpuguy83 cpuguy83 merged commit dd221a1 into moby:master Mar 7, 2017

4 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 31110 has succeeded
Details
janky Jenkins build Docker-PRs 39741 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 10789 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Mar 7, 2017

@dnephin dnephin deleted the dnephin:fix-override-default-stack-network branch Mar 7, 2017

@thaJeztah thaJeztah modified the milestones: 17.03.1, 17.04.0 Mar 7, 2017

@thaJeztah thaJeztah added this to PRs in 17.03.2-maybe Mar 7, 2017

@thaJeztah thaJeztah removed this from PRs in 17.03.2-maybe Mar 22, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 22, 2017

Member

cherry-picked into 17.03.1 through #31754

Member

thaJeztah commented Mar 22, 2017

cherry-picked into 17.03.1 through #31754

dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017

Merge pull request moby#31258 from dnephin/fix-override-default-stack…
…-network

Support customizing the default network for a stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment