New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown leaks an error when the container was never started #31279

Merged
merged 1 commit into from Feb 23, 2017

Conversation

Projects
None yet
6 participants
@aaronlehmann
Contributor

aaronlehmann commented Feb 23, 2017

I found that sometimes tasks would end up in a rejected state when trying to update them quickly. The problem was that Shutdown could fail if called before the container was started. Instead of returning an error in this case, Shutdown should succeed. This allows tasks to progress to the "shutdown" state as expected.

This was part of #31108 that I'm extracting into its own PR.

Shutdown leaks an error when the container was never started
I found that sometimes tasks would end up in a rejected state when
trying to update them quickly. The problem was that Shutdown could fail
if called before the container was started. Instead of returning an
error in this case, Shutdown should succeed. This allows tasks to
progress to the "shutdown" state as expected.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@aboch

This comment has been minimized.

Show comment
Hide comment
@aboch

aboch Feb 23, 2017

Contributor

Looks good to me

Contributor

aboch commented Feb 23, 2017

Looks good to me

@mavenugo

This comment has been minimized.

Show comment
Hide comment
@mavenugo

mavenugo Feb 23, 2017

Contributor

LGTM. thanks @aaronlehmann

Contributor

mavenugo commented Feb 23, 2017

LGTM. thanks @aaronlehmann

@dongluochen

This comment has been minimized.

Show comment
Hide comment
@dongluochen

dongluochen Feb 23, 2017

Contributor

lgtm (not a maintainer)

Contributor

dongluochen commented Feb 23, 2017

lgtm (not a maintainer)

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Feb 23, 2017

Collaborator

LGTM

Collaborator

vieux commented Feb 23, 2017

LGTM

@vieux vieux merged commit 52ba250 into moby:master Feb 23, 2017

4 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 31068 has succeeded
Details
janky Jenkins build Docker-PRs 39681 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 10747 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.04.0 milestone Feb 23, 2017

@vieux vieux referenced this pull request Feb 23, 2017

Merged

17.03 cherry-picks #31266

@vieux vieux modified the milestones: 17.03.0, 17.04.0 Feb 23, 2017

@aaronlehmann aaronlehmann deleted the aaronlehmann:shutdown-error-leakage branch Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment