New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format to the docker system df command #31482

Merged
merged 1 commit into from Apr 13, 2017

Conversation

@boaz1337
Contributor

boaz1337 commented Mar 2, 2017

- What I did
Add the format option to the docker-system-df command
related to #30431

- How I did it

  • Add the format option to the cli/command/system/df.go
  • Add the NewDiskUsageFormat function to return a right format from options in cli/command/formatter/disk_usage.go
  • Add unit tests

- How to verify it
TESTDIRS='cli/command/formatter/' TESTFLAGS='-test.run ^TestDiskUsage*' hack/make.sh test-unit

- Description for the changelog

  • Add format to docker-system-df

- A picture of a cute animal (not mandatory but encouraged)

todo: add to docs

@dnephin

LGTM

@vdemeester

LGTM 🐯
/cc @thaJeztah for docs-review
@ripcurld0 You will need to updates docs I think 👼

@boaz1337

This comment has been minimized.

Show comment
Hide comment
@boaz1337

boaz1337 Apr 3, 2017

Contributor

Yes I will.
Will do it tonight 😴

Contributor

boaz1337 commented Apr 3, 2017

Yes I will.
Will do it tonight 😴

@boaz1337

This comment has been minimized.

Show comment
Hide comment
@boaz1337

boaz1337 Apr 3, 2017

Contributor

DONE 😀 🎸 @thaJeztah

Contributor

boaz1337 commented Apr 3, 2017

DONE 😀 🎸 @thaJeztah

Add format to the docker system df command
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
<Paste>
```
**Note** the format option is meaningless when verbose is true.

This comment has been minimized.

@AkihiroSuda

AkihiroSuda Apr 12, 2017

Member

Should we error out this?

@AkihiroSuda

AkihiroSuda Apr 12, 2017

Member

Should we error out this?

This comment has been minimized.

@boaz1337

boaz1337 Apr 12, 2017

Contributor

Yep, we can. I will do that soon.

@boaz1337

boaz1337 Apr 12, 2017

Contributor

Yep, we can. I will do that soon.

This comment has been minimized.

@thaJeztah

thaJeztah Apr 13, 2017

Member

Perhaps;

> **Note**: the format option is ignored if `--verbose` is used

However, since you're planning to do a follow up to error out, let's keep it for now (you can remove it in that PR)

@thaJeztah

thaJeztah Apr 13, 2017

Member

Perhaps;

> **Note**: the format option is ignored if `--verbose` is used

However, since you're planning to do a follow up to error out, let's keep it for now (you can remove it in that PR)

This comment has been minimized.

@boaz1337

boaz1337 Apr 14, 2017

Contributor

👍

@boaz1337

boaz1337 Apr 14, 2017

Contributor

👍

@thaJeztah

docs LGTM, thanks!

@thaJeztah thaJeztah merged commit 0b35ab1 into moby:master Apr 13, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32760 has succeeded
Details
janky Jenkins build Docker-PRs 41370 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 1555 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 12494 has succeeded
Details
z Jenkins build Docker-PRs-s390x 1387 has succeeded
Details

@thaJeztah thaJeztah added this to the 17.06 milestone Apr 13, 2017

dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017

Merge pull request moby#31482 from ripcurld0/add_format_to_system_df
Add format to the docker system df command

@boaz1337 boaz1337 deleted the boaz1337:add_format_to_system_df branch Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment