New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Cleanup HCS on restore #31503

Merged
merged 1 commit into from Mar 13, 2017

Conversation

Projects
None yet
7 participants
@jhowardmsft
Contributor

jhowardmsft commented Mar 2, 2017

Signed-off-by: John Howard jhoward@microsoft.com

@darrenstahlmsft

This ensures that any compute processes in HCS are cleanedup
during daemon restore. Note Windows cannot (currently) reconnect
to containers on restore.

@friism @vieux Another one which should be considered for CS and servicing.

Windows: Cleanup HCS on restore
Signed-off-by: John Howard <jhoward@microsoft.com>

This ensures that any compute processes in HCS are cleanedup
during daemon restore. Note Windows cannot (currently) reconnect
to containers on restore.

@thaJeztah thaJeztah added this to the 17.03.1 milestone Mar 2, 2017

@thaJeztah thaJeztah added this to backlog in maintainers-session Mar 2, 2017

@thaJeztah thaJeztah removed this from backlog in maintainers-session Mar 2, 2017

@thaJeztah thaJeztah added this to PRs in 17.03.2-maybe Mar 2, 2017

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Mar 8, 2017

Contributor

@johnstep PTAL

Contributor

jhowardmsft commented Mar 8, 2017

@johnstep PTAL

@johnstep

LGTM

@darstahl

This comment has been minimized.

Show comment
Hide comment
@darstahl

darstahl Mar 9, 2017

Contributor

LGTM

Contributor

darstahl commented Mar 9, 2017

LGTM

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft
Contributor

jhowardmsft commented Mar 9, 2017

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Mar 10, 2017

Contributor

@thaJeztah Good to merge?

Contributor

jhowardmsft commented Mar 10, 2017

@thaJeztah Good to merge?

@vdemeester

LGTM 🐸

@vdemeester vdemeester merged commit 2fca652 into moby:master Mar 13, 2017

4 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 31261 has succeeded
Details
janky Jenkins build Docker-PRs 39877 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 10942 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/cleanuphcsonrestore branch Mar 13, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 22, 2017

Member

cherry-picked in #31754

Member

thaJeztah commented Mar 22, 2017

cherry-picked in #31754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment