New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--filter scope=swarm|local` for `docker network ls` #31529

Merged
merged 1 commit into from Mar 24, 2017

Conversation

@yongtang
Member

yongtang commented Mar 3, 2017

- What I did

This fix tries to address the request in #31324 by adding --filter scope=swarm|local for docker network ls.

As docker network ls has a SCOPE column by default, it is natural to add the support of --filter scope=swarm|local.

- How I did it

This fix adds the scope=swarm|local support for docker network ls --filter.

Related docs has been updated.

- How to verify it

Additional unit test cases have been added.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

maxresdefault

This fix fixes #31324.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@allencloud

This comment has been minimized.

Show comment
Hide comment
@allencloud

allencloud Mar 5, 2017

Contributor

I think we still need to update swagger.yml. WDYT? @yongtang

Contributor

allencloud commented Mar 5, 2017

I think we still need to update swagger.yml. WDYT? @yongtang

@yongtang

This comment has been minimized.

Show comment
Hide comment
@yongtang

yongtang Mar 5, 2017

Member

Thanks @allencloud. The PR has been updated with changes in swagger.yaml added.

Member

yongtang commented Mar 5, 2017

Thanks @allencloud. The PR has been updated with changes in swagger.yaml added.

@yongtang

This comment has been minimized.

Show comment
Hide comment
@yongtang

yongtang Mar 5, 2017

Member

@allencloud The PR has been updated. Thanks.

Member

yongtang commented Mar 5, 2017

@allencloud The PR has been updated. Thanks.

Show outdated Hide outdated api/swagger.yaml Outdated
@yongtang

This comment has been minimized.

Show comment
Hide comment
@yongtang

yongtang Mar 6, 2017

Member

Thanks @allencloud. The swagger.yaml, docs, and man have been updated.

Member

yongtang commented Mar 6, 2017

Thanks @allencloud. The swagger.yaml, docs, and man have been updated.

Show outdated Hide outdated man/src/network/ls.md Outdated
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 22, 2017

Member

Design, and code looks good to me, but needs a rebase @yongtang 😅

Member

thaJeztah commented Mar 22, 2017

Design, and code looks good to me, but needs a rebase @yongtang 😅

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Mar 22, 2017

Don't forget to add a mention to the API history; https://github.com/docker/docker/blob/master/docs/api/version-history.md

Show outdated Hide outdated api/swagger.yaml Outdated
@cpuguy83

LGTM

Show outdated Hide outdated docs/api/version-history.md Outdated
Add `--filter scope=swarm|local` for `docker network ls`
This fix tries to address the request in 31324 by adding
`--filter scope=swarm|local` for `docker network ls`.

As `docker network ls` has a `SCOPE` column by default,
it is natural to add the support of `--filter scope=swarm|local`.

This fix adds the `scope=swarm|local` support for
`docker network ls --filter`.

Related docs has been updated.

Additional unit test cases have been added.

This fix fixes 31324.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@vdemeester

LGTM 🐮
/cc @thaJeztah for docs-review 👼

@thaJeztah

LGTM! thanks!

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 24, 2017

Member

windows completed but failed to notify github

java.net.SocketTimeoutException: connect timed out
Finished: SUCCESS
Member

thaJeztah commented Mar 24, 2017

windows completed but failed to notify github

java.net.SocketTimeoutException: connect timed out
Finished: SUCCESS

@thaJeztah thaJeztah merged commit 4e290f7 into moby:master Mar 24, 2017

5 of 6 checks passed

windowsRS1 Jenkins build Docker-PRs-WoW-RS1 11704 is running
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32006 has succeeded
Details
janky Jenkins build Docker-PRs 40628 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 751 has succeeded
Details
z Jenkins build Docker-PRs-s390x 615 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 24, 2017

@albers

This comment has been minimized.

Show comment
Hide comment
@albers

albers Mar 24, 2017

Member

Thanks @yongtang!

Member

albers commented Mar 24, 2017

Thanks @yongtang!

@yongtang yongtang deleted the yongtang:31324-network-ls-filter-scope branch Mar 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment