Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support `--filter mode=global|replicated` for `docker service ls` #31538
- What I did
- How I did it
There are multiple ways to address the issue. One way is to pass the filter of mode to SwarmKit, another way is to process the filter of mode in the daemon.
This fix process the filter in the daemon.
NOTE: Alternatively, we could update SwarmKit to add the mode filter as well. Suggestion is welcomed if other way is preferred.
Related docs has been updated.
- How to verify it
An integration test has been added.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
This fix fixes #31325.
Signed-off-by: Yong Tang firstname.lastname@example.org
referenced this pull request
Mar 4, 2017
moved to docs review; @yongtang can you add a note to https://github.com/docker/docker/blob/master/docs/api/version-history.md#v128-api-changes to mention that a new filter is accepted by the API? Then I think we're ready to merge