Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix `docker build --label` when the label includes single quotes and a space #31750
Previously labels passed with
This PR also includes some refactoring, and additional unit test.
I had to add single quotes back to the value stored in the node because of #27174.
I'm thinking a better solution might be to add a new field to
The node would then be the source of truth instead of
As it is right now, we still strip off any quotes, so there is still an inconsistency with
What do you think?