New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display created tags on successful build #32077

Merged
merged 1 commit into from Mar 27, 2017

Conversation

Projects
None yet
6 participants
@zigarn
Contributor

zigarn commented Mar 24, 2017

- What I did

Display created tags on successful build:

$ docker build -t test -t zigarn/test -t test:1.0 -t zigarn/test:1.0 -t localhost:5000/test -t localhost:5000/test:1.0 .
Sending build context to Docker daemon  2.048kB
Step 1/2 : FROM alpine
 ---> 4a415e366388
Step 2/2 : CMD sh
 ---> Using cache
 ---> dc67a808676c
Successfully built dc67a808676c
Successfully tagged test:latest
Successfully tagged zigarn/test:latest
Successfully tagged test:1.0
Successfully tagged zigarn/test:1.0
Successfully tagged localhost:5000/test:latest
Successfully tagged localhost:5000/test:1.0

- How I did it

By adapting the code?

- How to verify it

Launch a build with one or more --tag options and see the output at the end of the build showing a "Successfully tagged ".

- Description for the changelog

Display created tags on successful build.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Mar 24, 2017

Member

Nice! Design, code LGTM ping @vdemeester

Member

thaJeztah commented Mar 24, 2017

Nice! Design, code LGTM ping @vdemeester

@vdemeester

Nice @zigarn 👍
LGTM (design & code) 🦁
/cc @tonistiigi (and @thaJeztah for docs 👼)

Display created tags on successful build
Signed-off-by: Alexandre Garnier <alexandre.garnier@zenika.com>
Signed-off-by: Alexandre Garnier <zigarn@gmail.com>
@dnephin

LGTM

@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Mar 27, 2017

Member

LGTM

Member

tonistiigi commented Mar 27, 2017

LGTM

@tonistiigi tonistiigi merged commit c5f178d into moby:master Mar 27, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32090 has succeeded
Details
janky Jenkins build Docker-PRs 40706 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 832 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 11783 has succeeded
Details
z Jenkins build Docker-PRs-s390x 693 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 27, 2017

gesellix added a commit to gesellix/docker-client that referenced this pull request Apr 18, 2017

Extract build image id in a more flexible way.
Necessary when using Docker above 17.05, due to moby/moby#32077.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment