New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup compose convert error messages #32087

Merged
merged 1 commit into from Mar 24, 2017

Conversation

Projects
6 participants
@dnephin
Member

dnephin commented Mar 24, 2017

  • error when the secret isn't defined in the Compose file
  • include the service name in error messages
Cleanup compose convert error messages.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@vdemeester

LGTM 🐯

@AkihiroSuda

LGTM

@nathanleclaire

This comment has been minimized.

Show comment
Hide comment
@nathanleclaire

nathanleclaire Mar 24, 2017

Contributor

Awesome @dnephin ! Thanks

Contributor

nathanleclaire commented Mar 24, 2017

Awesome @dnephin ! Thanks

@vdemeester vdemeester merged commit 3c22c7d into moby:master Mar 24, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32042 has succeeded
Details
janky Jenkins build Docker-PRs 40663 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 786 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 11739 has succeeded
Details
z Jenkins build Docker-PRs-s390x 650 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 24, 2017

@dnephin dnephin deleted the dnephin:check-secrets-against-defined branch Mar 24, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Apr 26, 2017

Member

Adding label "changelog", see #32822

Member

thaJeztah commented Apr 26, 2017

Adding label "changelog", see #32822

@thaJeztah thaJeztah added this to Triage in 17.04.1-maybe Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment