New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Fix setting command with custom shell #32236

Merged
merged 1 commit into from Mar 31, 2017

Conversation

Projects
None yet
4 participants
@tonistiigi
Member

tonistiigi commented Mar 30, 2017

fixes #31957

getShell returned a static array that is appended multiple times. Second append overrides the values for the previous one.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

builder: Fix setting command with custom shell
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@vdemeester

LGTM 🦁

@thaJeztah

LGTM

@thaJeztah thaJeztah merged commit 05cd8be into moby:master Mar 31, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32298 has succeeded
Details
janky Jenkins build Docker-PRs 40909 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 1073 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 12003 has succeeded
Details
z Jenkins build Docker-PRs-s390x 909 has succeeded
Details

@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment