New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoint mode loading from Compose file in stack deploy #32333

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
6 participants
@dnephin
Member

dnephin commented Apr 3, 2017

Fixes #32325

@dnephin dnephin added this to the 17.04.0 milestone Apr 3, 2017

Fix endpoint mode in Compose format.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Apr 4, 2017

Collaborator

LGTM

Collaborator

vieux commented Apr 4, 2017

LGTM

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Apr 4, 2017

Collaborator

@dnephin will go in 17.05

Collaborator

vieux commented Apr 4, 2017

@dnephin will go in 17.05

@dnephin dnephin modified the milestones: 17.05.0, 17.04.0 Apr 4, 2017

@boaz1337

LGTM 👍

@vdemeester vdemeester self-assigned this Apr 4, 2017

@vdemeester vdemeester self-requested a review Apr 4, 2017

@vdemeester

LGTM 🦁

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Apr 4, 2017

Member

relates to #31795

Member

thaJeztah commented Apr 4, 2017

relates to #31795

@vdemeester vdemeester merged commit 93ffbb7 into moby:master Apr 4, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32469 has succeeded
Details
janky Jenkins build Docker-PRs 41080 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 1251 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 12220 has succeeded
Details
z Jenkins build Docker-PRs-s390x 1086 has succeeded
Details

@dnephin dnephin deleted the dnephin:fix-endpoint-mode branch Apr 4, 2017

dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017

Merge pull request moby#32333 from dnephin/fix-endpoint-mode
Fix endpoint mode loading from Compose file in stack deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment