New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add the flag `--api-enable-cors` to deprecated.md #32352

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
4 participants
@KarthikNayak
Contributor

KarthikNayak commented Apr 4, 2017

Signed-off-by: Karthik Nayak Karthik.188@gmail.com

Carrying forward the discussion from #32174

- What I did

Added the flag --api-enable-cors to deprecated.md

- Description for the changelog

Add the flag --api-enable-cors to deprecated.md

Docs: Add the flag `--api-enable-cors` to deprecated.md
Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
@thaJeztah

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Apr 4, 2017

Member

ping @vieux PTAL this flag was marked deprecated a long time ago, but it was never added to "deprecated.md" (it did output a deprecation message). I thought it was good to keep it around for one "stable" release before removing it (so that it's at least documented in the deprecated features)

Member

thaJeztah commented Apr 4, 2017

ping @vieux PTAL this flag was marked deprecated a long time ago, but it was never added to "deprecated.md" (it did output a deprecation message). I thought it was good to keep it around for one "stable" release before removing it (so that it's at least documented in the deprecated features)

@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Apr 4, 2017

Collaborator

LGTM thanks @KarthikNayak

Collaborator

vieux commented Apr 4, 2017

LGTM thanks @KarthikNayak

@vieux vieux merged commit b9e9518 into moby:master Apr 4, 2017

1 check passed

dco-signed All commits are signed

@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Apr 4, 2017

@KarthikNayak KarthikNayak deleted the KarthikNayak:32174 branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment