New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ubuntu 12.04 "precise pangolin" from build scripts #32520

Merged
merged 1 commit into from Apr 11, 2017

Conversation

Projects
None yet
5 participants
@thaJeztah
Member

thaJeztah commented Apr 11, 2017

Ubuntu 12.04 will be EOL on April 28, after which it won't receive updates and security fixes;
https://lists.ubuntu.com/archives/ubuntu-announce/2017-March/000218.html

Ubuntu 12.04 was already removed from the installation documentation (and no docker-ce packages were built for this version of Ubuntu).

This patch removes Ubuntu 12.04 from the build scripts

Remove Ubuntu 12.04 "precise pangolin" from build scripts
Ubuntu 12.04 will be EOL on April 28, after which it won't
receive updates and security fixes;
https://lists.ubuntu.com/archives/ubuntu-announce/2017-March/000218.html

This patch removes Ubuntu 12.04 from the build scripts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
*) packages+=( libsystemd-dev );;
wheezy) ;;
jessie|trusty) packages+=( libsystemd-journal-dev ) ;;
*) packages+=( libsystemd-dev ) ;;

This comment has been minimized.

@thaJeztah

thaJeztah Apr 11, 2017

Member

my editor kept complaining about these lines 😅 /cc @albers @tianon

@thaJeztah

thaJeztah Apr 11, 2017

Member

my editor kept complaining about these lines 😅 /cc @albers @tianon

This comment has been minimized.

@albers

albers Apr 11, 2017

Member

;; is part of the case construct, probably needs to be a distinct word so that it does not get confused with the command delimiter ; (?)

@albers

albers Apr 11, 2017

Member

;; is part of the case construct, probably needs to be a distinct word so that it does not get confused with the command delimiter ; (?)

This comment has been minimized.

@thaJeztah

thaJeztah Apr 11, 2017

Member

@albers Is the change I made incorrect (I quickly tested it, and it seemed to work the same still), happy to change to what's best 😅

@thaJeztah

thaJeztah Apr 11, 2017

Member

@albers Is the change I made incorrect (I quickly tested it, and it seemed to work the same still), happy to change to what's best 😅

This comment has been minimized.

@albers

albers Apr 11, 2017

Member

@thaJeztah It's perfect with your change. I'm not sure if the added blank is actually required, but let's make your editor happy.

@albers

albers Apr 11, 2017

Member

@thaJeztah It's perfect with your change. I'm not sure if the added blank is actually required, but let's make your editor happy.

This comment has been minimized.

@thaJeztah

thaJeztah Apr 11, 2017

Member

👍 thanks!

@thaJeztah

thaJeztah Apr 11, 2017

Member

👍 thanks!

This comment has been minimized.

@tianon

tianon Apr 11, 2017

Member

😍

@tianon

tianon Apr 11, 2017

Member

😍

This comment has been minimized.

@thaJeztah

thaJeztah Apr 11, 2017

Member

Thank JetBrains, they do a great job in pointing out issues 👍

@thaJeztah

thaJeztah Apr 11, 2017

Member

Thank JetBrains, they do a great job in pointing out issues 👍

@vdemeester

LGTM 🐮

@tianon

tianon approved these changes Apr 11, 2017

Very nice! LGTM

*) packages+=( libsystemd-dev );;
wheezy) ;;
jessie|trusty) packages+=( libsystemd-journal-dev ) ;;
*) packages+=( libsystemd-dev ) ;;

This comment has been minimized.

@tianon

tianon Apr 11, 2017

Member

😍

@tianon

tianon Apr 11, 2017

Member

😍

@vdemeester vdemeester merged commit 595f1c4 into moby:master Apr 11, 2017

5 of 6 checks passed

windowsRS1 Jenkins build Docker-PRs-WoW-RS1 12569 has failed
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 32828 has succeeded
Details
janky Jenkins build Docker-PRs 41437 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 1628 has succeeded
Details
z Jenkins build Docker-PRs-s390x 1461 has succeeded
Details

@thaJeztah thaJeztah deleted the thaJeztah:remove-ubuntu-12.04-precise branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment