Join GitHub today
Support Custom Secret Targets #32571
This adds support for custom secret target paths lifting the restriction of limiting secrets to
2 times, most recently
Apr 13, 2017
@ehazlett: I'd suggest this borrow the code from configs in #32336. That stores the config under the full target path, so there isn't a risk of collisions from targets that share the same basename. Also, it would be good for the config and secret implementations to stay consistent.
Let me know if it would be helpful for me to carry this PR.
Force-pushed to rebase and change the "local" storage paths to use the full target path instead of just the basename (which could collide).
When I have a chance (either later today or early next week), I'll expand the automated tests to check that the files actually exist inside the container in the right places, with the right content, using both relative and absolute paths. I'll also improve the tests to cover invalid targets and referencing the same secret twice under different targets.
This seems to happen with any secret target right now.
And I end up with leaked mounts: