New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "labels" to compose 3.3 format #32972

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
6 participants
@thaJeztah
Member

thaJeztah commented May 2, 2017

Commit bb5dfdb (#32632) added a labels option to the docker-compose file format, but added it to the 3.2 schema.

This patch moves the change to the 3.3 schema

This should go in after #32743 was merged (and will have to be rebased then)

Move "labels" to compose 3.3 format
Commit bb5dfdb added a
labels option to the docker-compose file format, but
added it to the 3.2 schema.

This patch moves the change to the 3.3 schema

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux May 3, 2017

Collaborator

ping @dnephin

Collaborator

vieux commented May 3, 2017

ping @dnephin

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin May 3, 2017

Member

LGTM

Member

dnephin commented May 3, 2017

LGTM

@vdemeester

LGTM 🐯

@cpuguy83 cpuguy83 merged commit 4662d3e into moby:master May 5, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 33541 has succeeded
Details
janky Jenkins build Docker-PRs 42146 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 2433 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 13467 has succeeded
Details
z Jenkins build Docker-PRs-s390x 2222 has succeeded
Details

@thaJeztah thaJeztah deleted the thaJeztah:compose-move-labels-to-3.3 branch May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment