Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.03.2] cluster: Renew the context after communicating with the registry #33117

Merged
merged 1 commit into from May 10, 2017

Conversation

@aaronlehmann
Copy link
Contributor

commented May 9, 2017

Cherry-pick of #31586

When pinning by digest, the registry might be slow or unresponsive. This
could cause the context to already be expired by the time UpdateService
or CreateService is called. We want digest pinning to be a best-effort
operation, so it's problematic if a slow or misbehaving registry
prevents the service operation from completing. Replace the context
after communicating with the registry, so we have a fresh timeout for
the gRPC call.

cc @thaJeztah

cluster: Renew the context after communicating with the registry
When pinning by digest, the registry might be slow or unresponsive. This
could cause the context to already be expired by the time UpdateService
or CreateService is called. We want digest pinning to be a best-effort
operation, so it's problematic if a slow or misbehaving registry
prevents the service operation from completing. Replace the context
after communicating with the registry, so we have a fresh timeout for
the gRPC call.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
(cherry picked from commit f8273a2)
@thaJeztah
Copy link
Member

left a comment

LGTM, thanks!

@thaJeztah thaJeztah added this to Picked in 17.03.2-maybe May 9, 2017

@cpuguy83
Copy link
Contributor

left a comment

LGTM

@mlaventure

This comment has been minimized.

Copy link
Contributor

commented May 9, 2017

z errors look real to me, but they don't seem related to this PR 🤷‍♂

@thaJeztah

This comment has been minimized.

Copy link
Member

commented May 10, 2017

All green now - merging.

Thanks @aaronlehmann !

@thaJeztah thaJeztah merged commit 7f394b8 into moby:17.03.x May 10, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 33872 has succeeded
Details
janky Jenkins build Docker-PRs 42470 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 2820 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 13702 has succeeded
Details
z Jenkins build Docker-PRs-s390x 2616 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants
You can’t perform that action at this time.