[17.03] Fix issue backporting mount spec to pre-1.13 obj #33207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
May 15, 2017
daemon/volumes.go
Outdated
| from, _, err := volume.ParseVolumesFrom(fromSpec) | ||
| if err != nil { | ||
| logrus.WithError(err).WithField("id", container.ID).Error("Error reading volumes-from spec during mount spec backport") | ||
| } |
There was a problem hiding this comment.
May have missed this in the original PR as well, need a continue here 😓
thaJeztah
requested changes
May 15, 2017
In some cases a mount spec would not be properly backported which could lead to accidental removal of the underlying volume on container remove (which should never happen with named volumes). Adds unit tests for this as well. Unfortunately I had to add a daemon depdency for the backport function due to looking up `VolumesFrom` specs. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 3cf1859) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
cherry_pick_mpsec_backport
branch
from
7976d2f
to
d772750
Compare
|
All green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #32821 to 17.03 for 17.03.2
ping @thaJeztah @mlaventure