Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Prefer digest over tag on pull #33214
I don't believe this code was originally considering the case where both a tag and digest are given, I believe it was impossible when it was originally written. Is it still adding the tag when both are given? I agree this is the correct ordering but want to make sure the rest of the code is handling it properly. What code paths currently allow passing in both?
No, it stores it under the digest in this case. I think this is the correct behavior, because we don't want to overwrite the tag with an older version that we pulled by digest.