Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for DNS search on RS1 #33311

Merged
merged 1 commit into from May 30, 2017

Conversation

@msabansal
Copy link
Contributor

commented May 20, 2017

Signed-off-by: Sandeep Bansal sabansal@microsoft.com

- What I did
With the next windows update we are backporting the ability to allow DNS-search on RS1 platforms. As a result the dns-search option will be applicable to rs1 aswell. Removing the version check in order to support that.
- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Adding support for DNS search on RS1
Signed-off-by: Sandeep Bansal <sabansal@microsoft.com>
@jhowardmsft
Copy link
Contributor

left a comment

LGTM

@jhowardmsft

This comment has been minimized.

Copy link
Contributor

commented May 26, 2017

@johnstep PTAL

@jhowardmsft

This comment has been minimized.

Copy link
Contributor

commented May 26, 2017

@thaJeztah this should hit 17.06 if possible

@johnstep
Copy link
Member

left a comment

LGTM

@thaJeztah
Copy link
Member

left a comment

LGTM

@thaJeztah thaJeztah merged commit 4bf8714 into moby:master May 30, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 34377 has succeeded
Details
janky Jenkins build Docker-PRs 42975 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 3362 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 14231 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3085 has succeeded
Details
@thaJeztah thaJeztah referenced this pull request May 30, 2017
23 of 23 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.