Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not clear swarm directory on `swarm init` and `swarm join` #33341
However, this continues to clear the directory if init fails, because we don't want to leave it in a half-finished state.
This would fix #33216 to be compatible with the method for pre-generating external CA certs that was in 17.03.
This would also allow the extra flags as suggested in #33216 to be added after 17.06 if necessary.
@aaronlehmann That seems like a good idea - is there any reason we'd want to keep state from prior to a join, though?
Similarly, if init fails, the pre-generated certificates would also be wiped out, which seems ok to me but may be inconvenient for users to have to re-generate (although I'd like to deprecate having to do that anyway).
I don't think so.
I think the reason we need to remove it after a failed join is to avoid ending up with an inconsistent state that prevents a second
1 similar comment
May 23, 2017
6 checks passed
@aaronlehmann 17.06 already branched, but we may have to remove milestones from this repository, because moby milestones != docker milestones
Understood, but let's please make sure the bot does not add misleading milestones. What do we need to do to make sure this gets cherry-picked downstream?